Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream dogstatsd refactors #617

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Upstream dogstatsd refactors #617

wants to merge 31 commits into from

Conversation

alexgallotta
Copy link
Contributor

  • remove extra structs not needed
  • fixed false positive wrong tag format
  • optimization: avoid extra sorting for id
  • optimization: use ustr everywhere for tags

@pr-commenter
Copy link

pr-commenter bot commented Sep 9, 2024 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2024-09-20 17:35:45

Comparing candidate commit 54ebc07 in PR branch upstream-dogstatsd-refactors with baseline commit 13eac56 in branch main.

Found 19 performance improvements and 19 performance regressions! Performance is the same for 13 metrics, 2 unstable metrics.

scenario:benching deserializing traces from msgpack to their internal representation

  • 🟥 execution_time [+42.908ns; +52.112ns] or [+3.530%; +4.287%]

scenario:benching string interning on wordpress profile

  • 🟩 execution_time [-5.035µs; -4.850µs] or [-3.498%; -3.370%]

scenario:credit_card/is_card_number/

  • 🟩 execution_time [-803.214ns; -802.869ns] or [-33.237%; -33.222%]
  • 🟩 throughput [+205882294.530op/s; +205981539.312op/s] or [+49.755%; +49.779%]

scenario:credit_card/is_card_number/ 3782-8224-6310-005

  • 🟥 execution_time [+5.396µs; +5.779µs] or [+4.656%; +4.986%]
  • 🟥 throughput [-412123.618op/s; -383627.741op/s] or [-4.776%; -4.446%]

scenario:credit_card/is_card_number/ 378282246310005

  • 🟥 execution_time [+4.618µs; +5.033µs] or [+4.295%; +4.681%]
  • 🟥 throughput [-418430.476op/s; -383062.562op/s] or [-4.498%; -4.118%]

scenario:credit_card/is_card_number/37828224631

  • 🟩 execution_time [-803.243ns; -802.610ns] or [-33.237%; -33.211%]
  • 🟩 throughput [+205791537.332op/s; +205970173.608op/s] or [+49.733%; +49.777%]

scenario:credit_card/is_card_number/378282246310005

  • 🟥 execution_time [+2.420µs; +2.854µs] or [+2.285%; +2.696%]
  • 🟥 throughput [-250722.095op/s; -211665.477op/s] or [-2.654%; -2.241%]

scenario:credit_card/is_card_number/37828224631000521389798

  • 🟥 execution_time [+5.358µs; +5.505µs] or [+5.029%; +5.168%]
  • 🟥 throughput [-461726.932op/s; -449116.413op/s] or [-4.919%; -4.785%]

scenario:credit_card/is_card_number_no_luhn/

  • 🟩 execution_time [-802.935ns; -802.544ns] or [-33.228%; -33.211%]
  • 🟩 throughput [+205791520.944op/s; +205918097.830op/s] or [+49.729%; +49.760%]

scenario:credit_card/is_card_number_no_luhn/ 3782-8224-6310-005

  • 🟥 execution_time [+8.871µs; +8.981µs] or [+10.163%; +10.289%]
  • 🟥 throughput [-1069099.268op/s; -1056408.444op/s] or [-9.332%; -9.221%]

scenario:credit_card/is_card_number_no_luhn/ 378282246310005

  • 🟥 execution_time [+7.407µs; +7.621µs] or [+9.223%; +9.490%]
  • 🟥 throughput [-1082282.209op/s; -1050218.591op/s] or [-8.691%; -8.434%]

scenario:credit_card/is_card_number_no_luhn/37828224631

  • 🟩 execution_time [-803.154ns; -802.788ns] or [-33.234%; -33.219%]
  • 🟩 throughput [+205866399.131op/s; +205953874.040op/s] or [+49.750%; +49.771%]

scenario:credit_card/is_card_number_no_luhn/378282246310005

  • 🟥 execution_time [+6.673µs; +6.836µs] or [+8.655%; +8.866%]
  • 🟥 throughput [-1058319.421op/s; -1032060.216op/s] or [-8.160%; -7.957%]

scenario:credit_card/is_card_number_no_luhn/37828224631000521389798

  • 🟥 execution_time [+5.236µs; +5.372µs] or [+4.911%; +5.038%]
  • 🟥 throughput [-450206.341op/s; -438670.994op/s] or [-4.801%; -4.678%]

scenario:normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...

  • 🟩 execution_time [-19.768µs; -18.435µs] or [-7.157%; -6.675%]
  • 🟩 throughput [+260395.731op/s; +280283.645op/s] or [+7.192%; +7.741%]

scenario:normalization/normalize_name/normalize_name/bad-name

  • 🟩 execution_time [-5.566µs; -5.513µs] or [-19.800%; -19.612%]
  • 🟩 throughput [+8683857.726op/s; +8784289.873op/s] or [+24.409%; +24.691%]

scenario:normalization/normalize_name/normalize_name/good

  • 🟩 execution_time [-2.671µs; -2.648µs] or [-16.313%; -16.173%]
  • 🟩 throughput [+11791339.152op/s; +11895943.156op/s] or [+19.308%; +19.480%]

scenario:normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters

  • 🟥 execution_time [+9.432µs; +9.558µs] or [+5.092%; +5.159%]
  • 🟥 throughput [-264860.373op/s; -261473.996op/s] or [-4.907%; -4.844%]

scenario:normalization/normalize_trace/test_trace

  • 🟩 execution_time [-24.043ns; -18.821ns] or [-7.801%; -6.107%]

scenario:redis/obfuscate_redis_string

  • 🟩 execution_time [-2.033µs; -1.598µs] or [-5.120%; -4.025%]

scenario:sql/obfuscate_sql_string

  • 🟩 execution_time [-2.305µs; -2.243µs] or [-3.137%; -3.054%]

scenario:tags/replace_trace_tags

  • 🟩 execution_time [-96.142ns; -89.673ns] or [-3.455%; -3.223%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 54ebc07 1726853130 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.384µs 3.226µs ± 1.392µs 3.097µs ± 0.026µs 3.120µs 3.203µs 13.979µs 14.947µs 382.63% 7.632 58.535 43.04% 0.098µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.034µs; 3.419µs] or [-5.980%; +5.980%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 54ebc07 1726853130 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.165µs 24.451µs ± 11.415µs 18.702µs ± 0.253µs 28.106µs 42.954µs 48.692µs 95.667µs 411.52% 2.748 11.241 46.57% 0.807µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [22.869µs; 26.033µs] or [-6.470%; +6.470%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 54ebc07 1726853130 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 251.370µs 257.092µs ± 4.803µs 257.074µs ± 4.305µs 259.404µs 267.010µs 269.572µs 270.075µs 5.06% 0.791 -0.045 1.86% 0.340µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3702670.318op/s 3890989.030op/s ± 71689.598op/s 3889923.278op/s ± 65558.924op/s 3962824.495op/s 3969898.039op/s 3973517.317op/s 3978199.977op/s 2.27% -0.719 -0.216 1.84% 5069.220op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 22.173µs 22.569µs ± 0.181µs 22.574µs ± 0.129µs 22.692µs 22.877µs 22.934µs 22.941µs 1.62% 0.114 -0.711 0.80% 0.013µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 43590510.742op/s 44310562.305op/s ± 354494.673op/s 44298376.174op/s ± 255445.654op/s 44577138.554op/s 44866307.557op/s 45042068.263op/s 45100025.707op/s 1.81% -0.084 -0.712 0.80% 25066.559op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 13.635µs 13.715µs ± 0.063µs 13.705µs ± 0.019µs 13.730µs 13.765µs 13.794µs 14.503µs 5.82% 9.748 118.572 0.46% 0.004µs 1 200
normalization/normalize_name/normalize_name/good throughput 68953091.879op/s 72912059.421op/s ± 321889.555op/s 72965169.172op/s ± 102765.326op/s 73043157.609op/s 73145888.158op/s 73193138.779op/s 73342315.795op/s 0.52% -9.398 112.728 0.44% 22761.029op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [256.426µs; 257.758µs] or [-0.259%; +0.259%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3881053.541op/s; 3900924.519op/s] or [-0.255%; +0.255%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [22.544µs; 22.594µs] or [-0.111%; +0.111%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [44261432.753op/s; 44359691.857op/s] or [-0.111%; +0.111%] None None None
normalization/normalize_name/normalize_name/good execution_time [13.707µs; 13.724µs] or [-0.064%; +0.064%] None None None
normalization/normalize_name/normalize_name/good throughput [72867448.624op/s; 72956670.217op/s] or [-0.061%; +0.061%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 54ebc07 1726853130 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 275.433ns 286.776ns ± 13.901ns 280.775ns ± 3.419ns 290.936ns 319.168ns 330.556ns 335.213ns 19.39% 1.693 1.986 4.84% 0.983ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [284.849ns; 288.702ns] or [-0.672%; +0.672%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 54ebc07 1726853130 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 137.908µs 138.981µs ± 0.471µs 138.931µs ± 0.212µs 139.143µs 139.587µs 140.225µs 142.638µs 2.67% 3.241 20.767 0.34% 0.033µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [138.915µs; 139.046µs] or [-0.047%; +0.047%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 54ebc07 1726853130 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.205µs 1.263µs ± 0.024µs 1.259µs ± 0.025µs 1.287µs 1.290µs 1.291µs 1.291µs 2.54% -0.783 -0.125 1.93% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.260µs; 1.267µs] or [-0.268%; +0.268%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 54ebc07 1726853130 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 539.913µs 540.545µs ± 0.289µs 540.485µs ± 0.174µs 540.756µs 540.967µs 541.333µs 541.734µs 0.23% 0.688 1.585 0.05% 0.020µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1845925.022op/s 1849985.314op/s ± 988.267op/s 1850190.214op/s ± 594.056op/s 1850480.162op/s 1851486.130op/s 1851796.388op/s 1852150.254op/s 0.11% -0.683 1.569 0.05% 69.881op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 466.801µs 467.634µs ± 0.330µs 467.609µs ± 0.191µs 467.833µs 468.194µs 468.333µs 469.013µs 0.30% 0.260 0.981 0.07% 0.023µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2132135.627op/s 2138427.495op/s ± 1510.912op/s 2138540.507op/s ± 873.989op/s 2139317.116op/s 2141036.232op/s 2141779.353op/s 2142240.484op/s 0.17% -0.254 0.969 0.07% 106.838op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 193.805µs 194.749µs ± 0.396µs 194.852µs ± 0.292µs 195.074µs 195.246µs 195.365µs 195.416µs 0.29% -0.513 -0.779 0.20% 0.028µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5117283.423op/s 5134844.153op/s ± 10444.145op/s 5132112.390op/s ± 7688.686op/s 5143495.400op/s 5153303.405op/s 5159345.433op/s 5159829.101op/s 0.54% 0.519 -0.771 0.20% 738.513op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 44.458µs 44.770µs ± 0.142µs 44.757µs ± 0.090µs 44.849µs 45.031µs 45.132µs 45.169µs 0.92% 0.555 0.022 0.32% 0.010µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 22138991.394op/s 22336618.911op/s ± 70883.887op/s 22343002.058op/s ± 44985.770op/s 22385850.020op/s 22440217.345op/s 22462508.613op/s 22493296.364op/s 0.67% -0.539 0.002 0.32% 5012.248op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 50.308µs 50.726µs ± 0.133µs 50.725µs ± 0.098µs 50.827µs 50.933µs 50.999µs 51.028µs 0.60% -0.212 0.021 0.26% 0.009µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19597244.719op/s 19713927.717op/s ± 51912.662op/s 19714115.543op/s ± 37896.096op/s 19749808.980op/s 19797245.892op/s 19847569.531op/s 19877641.559op/s 0.83% 0.228 0.041 0.26% 3670.780op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [540.505µs; 540.585µs] or [-0.007%; +0.007%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1849848.350op/s; 1850122.279op/s] or [-0.007%; +0.007%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [467.588µs; 467.679µs] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2138218.098op/s; 2138636.893op/s] or [-0.010%; +0.010%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [194.694µs; 194.804µs] or [-0.028%; +0.028%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5133396.695op/s; 5136291.611op/s] or [-0.028%; +0.028%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [44.750µs; 44.790µs] or [-0.044%; +0.044%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [22326795.086op/s; 22346442.736op/s] or [-0.044%; +0.044%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [50.707µs; 50.744µs] or [-0.036%; +0.036%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [19706733.121op/s; 19721122.313op/s] or [-0.036%; +0.036%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 54ebc07 1726853130 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.620µs 2.689µs ± 0.022µs 2.692µs ± 0.012µs 2.704µs 2.728µs 2.734µs 2.736µs 1.63% -0.683 1.135 0.81% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.686µs; 2.692µs] or [-0.112%; +0.112%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 54ebc07 1726853130 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 37.329µs 37.884µs ± 1.039µs 37.407µs ± 0.025µs 37.447µs 40.118µs 40.136µs 40.965µs 9.51% 1.719 1.007 2.74% 0.073µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [37.740µs; 38.028µs] or [-0.380%; +0.380%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 54ebc07 1726853130 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.043ms 9.076ms ± 0.014ms 9.076ms ± 0.010ms 9.086ms 9.097ms 9.105ms 9.109ms 0.37% -0.071 -0.415 0.15% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.074ms; 9.077ms] or [-0.021%; +0.021%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 54ebc07 1726853130 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 71.053µs 71.178µs ± 0.167µs 71.156µs ± 0.027µs 71.187µs 71.241µs 71.774µs 73.195µs 2.87% 9.574 107.284 0.23% 0.012µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [71.155µs; 71.202µs] or [-0.033%; +0.033%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 54ebc07 1726853130 upstream-dogstatsd-refactors
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 1.613µs 1.614µs ± 0.001µs 1.614µs ± 0.000µs 1.614µs 1.615µs 1.615µs 1.622µs 0.52% 5.056 46.188 0.05% 0.000µs 1 200
credit_card/is_card_number/ throughput 616548082.891op/s 619726908.332op/s ± 321911.361op/s 619763029.902op/s ± 173830.182op/s 619945467.408op/s 620022352.721op/s 620063281.437op/s 620117214.862op/s 0.06% -5.021 45.716 0.05% 22762.571op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 120.662µs 121.500µs ± 0.310µs 121.521µs ± 0.193µs 121.713µs 121.970µs 122.159µs 122.409µs 0.73% -0.105 -0.072 0.25% 0.022µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 8169318.677op/s 8230498.997op/s ± 21015.833op/s 8229017.727op/s ± 13100.759op/s 8242241.670op/s 8265137.653op/s 8277729.038op/s 8287589.335op/s 0.71% 0.120 -0.076 0.25% 1486.044op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 109.903µs 112.345µs ± 0.591µs 112.377µs ± 0.307µs 112.656µs 113.270µs 113.563µs 113.776µs 1.24% -1.046 3.406 0.52% 0.042µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 8789221.531op/s 8901423.642op/s ± 47090.430op/s 8898621.182op/s ± 24394.846op/s 8923297.397op/s 8964711.169op/s 9072013.660op/s 9098901.998op/s 2.25% 1.115 3.616 0.53% 3329.796op/s 1 200
credit_card/is_card_number/37828224631 execution_time 1.613µs 1.614µs ± 0.002µs 1.614µs ± 0.000µs 1.614µs 1.614µs 1.615µs 1.633µs 1.18% 10.336 125.686 0.09% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 612432679.835op/s 619670162.749op/s ± 575154.795op/s 619663302.276op/s ± 146885.915op/s 619918993.451op/s 620003078.909op/s 620071268.160op/s 620154914.658op/s 0.08% -10.278 124.652 0.09% 40669.586op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 106.116µs 108.516µs ± 0.493µs 108.463µs ± 0.265µs 108.814µs 109.293µs 109.621µs 109.733µs 1.17% -0.811 4.092 0.45% 0.035µs 1 200
credit_card/is_card_number/378282246310005 throughput 9113012.824op/s 9215426.525op/s ± 41987.469op/s 9219747.172op/s ± 22486.182op/s 9237096.990op/s 9263748.498op/s 9378387.727op/s 9423648.636op/s 2.21% 0.886 4.389 0.45% 2968.962op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 111.121µs 111.966µs ± 0.312µs 111.951µs ± 0.207µs 112.161µs 112.497µs 112.691µs 112.918µs 0.86% 0.194 0.221 0.28% 0.022µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 8855970.917op/s 8931330.833op/s ± 24858.162op/s 8932444.815op/s ± 16500.327op/s 8948663.308op/s 8962745.771op/s 8995213.557op/s 8999170.277op/s 0.75% -0.176 0.219 0.28% 1757.737op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 21.970µs 22.397µs ± 0.239µs 22.360µs ± 0.152µs 22.535µs 22.856µs 23.011µs 23.136µs 3.47% 0.684 0.116 1.07% 0.017µs 1 200
credit_card/is_card_number/x371413321323331 throughput 43222462.251op/s 44653373.222op/s ± 473677.293op/s 44721855.270op/s ± 304278.223op/s 44989631.428op/s 45340251.603op/s 45443767.093op/s 45516747.674op/s 1.78% -0.632 0.023 1.06% 33494.043op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 1.613µs 1.614µs ± 0.001µs 1.614µs ± 0.000µs 1.614µs 1.615µs 1.616µs 1.626µs 0.77% 6.815 69.704 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 614959286.481op/s 619680856.602op/s ± 433465.764op/s 619717019.908op/s ± 185394.636op/s 619927798.116op/s 620027258.592op/s 620080981.637op/s 620092621.708op/s 0.06% -6.763 68.904 0.07% 30650.658op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 95.337µs 96.215µs ± 0.327µs 96.257µs ± 0.235µs 96.407µs 96.778µs 96.862µs 97.064µs 0.84% -0.156 -0.057 0.34% 0.023µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 10302477.776op/s 10393472.229op/s ± 35311.024op/s 10388881.303op/s ± 25365.722op/s 10418774.372op/s 10455663.451op/s 10478987.646op/s 10489155.726op/s 0.97% 0.176 -0.047 0.34% 2496.866op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 85.729µs 87.825µs ± 0.249µs 87.801µs ± 0.144µs 87.985µs 88.178µs 88.351µs 88.415µs 0.70% -2.710 23.477 0.28% 0.018µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 11310303.637op/s 11386400.611op/s ± 32542.514op/s 11389366.887op/s ± 18681.084op/s 11404633.424op/s 11423381.213op/s 11432633.871op/s 11664643.942op/s 2.42% 2.868 25.093 0.29% 2301.103op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 1.613µs 1.614µs ± 0.001µs 1.614µs ± 0.000µs 1.614µs 1.615µs 1.616µs 1.616µs 0.14% 0.729 0.110 0.04% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 618907967.946op/s 619709517.407op/s ± 246445.712op/s 619755563.551op/s ± 175533.139op/s 619918280.408op/s 620021142.941op/s 620065030.055op/s 620120416.219op/s 0.06% -0.727 0.105 0.04% 17426.343op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 83.248µs 83.857µs ± 0.254µs 83.855µs ± 0.189µs 84.033µs 84.296µs 84.457µs 84.775µs 1.10% 0.300 0.135 0.30% 0.018µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 11795996.498op/s 11925195.685op/s ± 36141.144op/s 11925347.920op/s ± 26879.625op/s 11952952.906op/s 11979194.421op/s 12000275.360op/s 12012283.761op/s 0.73% -0.282 0.106 0.30% 2555.565op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 111.125µs 111.936µs ± 0.300µs 111.897µs ± 0.169µs 112.094µs 112.515µs 112.754µs 112.825µs 0.83% 0.572 0.426 0.27% 0.021µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 8863284.720op/s 8933737.830op/s ± 23931.381op/s 8936756.368op/s ± 13503.891op/s 8949307.097op/s 8968882.428op/s 8980029.917op/s 8998853.546op/s 0.69% -0.555 0.409 0.27% 1692.204op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 21.798µs 22.328µs ± 0.218µs 22.307µs ± 0.145µs 22.461µs 22.684µs 22.979µs 23.055µs 3.35% 0.532 0.445 0.97% 0.015µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 43375471.442op/s 44791827.680op/s ± 435088.811op/s 44829589.932op/s ± 292352.171op/s 45085399.923op/s 45432588.348op/s 45603340.761op/s 45876679.798op/s 2.34% -0.469 0.340 0.97% 30765.425op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [1.613µs; 1.614µs] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/ throughput [619682294.513op/s; 619771522.150op/s] or [-0.007%; +0.007%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [121.457µs; 121.543µs] or [-0.035%; +0.035%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [8227586.405op/s; 8233411.590op/s] or [-0.035%; +0.035%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [112.263µs; 112.427µs] or [-0.073%; +0.073%] None None None
credit_card/is_card_number/ 378282246310005 throughput [8894897.362op/s; 8907949.923op/s] or [-0.073%; +0.073%] None None None
credit_card/is_card_number/37828224631 execution_time [1.614µs; 1.614µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/37828224631 throughput [619590451.826op/s; 619749873.672op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/378282246310005 execution_time [108.448µs; 108.584µs] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/378282246310005 throughput [9209607.465op/s; 9221245.584op/s] or [-0.063%; +0.063%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [111.923µs; 112.009µs] or [-0.039%; +0.039%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [8927885.731op/s; 8934775.935op/s] or [-0.039%; +0.039%] None None None
credit_card/is_card_number/x371413321323331 execution_time [22.364µs; 22.430µs] or [-0.148%; +0.148%] None None None
credit_card/is_card_number/x371413321323331 throughput [44587726.105op/s; 44719020.339op/s] or [-0.147%; +0.147%] None None None
credit_card/is_card_number_no_luhn/ execution_time [1.614µs; 1.614µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ throughput [619620782.416op/s; 619740930.788op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [96.170µs; 96.261µs] or [-0.047%; +0.047%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [10388578.461op/s; 10398365.998op/s] or [-0.047%; +0.047%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [87.790µs; 87.859µs] or [-0.039%; +0.039%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [11381890.532op/s; 11390910.691op/s] or [-0.040%; +0.040%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [1.614µs; 1.614µs] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [619675362.402op/s; 619743672.413op/s] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [83.822µs; 83.892µs] or [-0.042%; +0.042%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [11920186.870op/s; 11930204.500op/s] or [-0.042%; +0.042%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [111.894µs; 111.978µs] or [-0.037%; +0.037%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [8930421.170op/s; 8937054.489op/s] or [-0.037%; +0.037%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [22.297µs; 22.358µs] or [-0.135%; +0.135%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [44731528.555op/s; 44852126.805op/s] or [-0.135%; +0.135%] None None None

Baseline

Omitted due to size.

@alexgallotta alexgallotta marked this pull request as ready for review September 9, 2024 19:58
@alexgallotta alexgallotta requested review from a team as code owners September 9, 2024 19:58
@alexgallotta alexgallotta removed the request for review from purple4reina September 9, 2024 20:01
taegyunkim
taegyunkim requested changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@taegyunkim taegyunkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix lint and 3rd party license checks.

@alexgallotta alexgallotta force-pushed the upstream-dogstatsd-refactors branch 2 times, most recently from d00227d to f70afed Compare September 11, 2024 23:19
@alexgallotta alexgallotta requested a review from a team as a code owner September 18, 2024 17:31
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.90909% with 9 lines in your changes missing coverage. Please review.

Project coverage is 73.62%. Comparing base (13eac56) to head (54ebc07).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
+ Coverage   73.58%   73.62%   +0.04%     
==========================================
  Files         255      255              
  Lines       36941    36899      -42     
==========================================
- Hits        27182    27167      -15     
+ Misses       9759     9732      -27
Components Coverage Δ
crashtracker 20.53% <ø> (ø)
datadog-alloc 98.73% <ø> (+0.14%) ⬆️
data-pipeline 91.65% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.08% <ø> (ø)
ddcommon-ffi 69.52% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ipc 83.58% <ø> (ø)
profiling 84.26% <ø> (ø)
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <0.00%> (ø)
sidecar 40.10% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.47% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.41% <ø> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taegyunkim taegyunkim taegyunkim approved these changes

@astuyve astuyve Awaiting requested review from astuyve

@duncanista duncanista Awaiting requested review from duncanista

@duncanpharvey duncanpharvey Awaiting requested review from duncanpharvey

Assignees
No one assigned
Labels
mini-agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexgallotta @codecov-commenter @taegyunkim