Health Metrics for data-pipeline #618
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajgajg1134
changed the title
ekump
reviewed
Sep 11, 2024
ekump
reviewed
Sep 11, 2024
ekump
reviewed
Sep 11, 2024
| @@ -1,4 +1,4 @@ | |||
| // Copyright 2021-Present Datadog, Inc. https://www.datadoghq.com/ | |||
| // Copyright 2024-Present Datadog, Inc. https://www.datadoghq.com/ | |||
There was a problem hiding this comment.
I have no clue what the correct answer is, but should we be modifying the license headers like this? I'm not sure what is legally correct.
There was a problem hiding this comment.
iirc it doesn't strictly matter as long as the header is there when the file is created
ekump
reviewed
Sep 11, 2024
data-pipeline/src/trace_exporter.rs
Outdated
| @@ -213,23 +231,36 @@ impl TraceExporter { | |||
| return Ok(String::from("{}")); | |||
| } | |||
|
|
|||
| // todo: do we need to modify the client to allow for &str to avoid allocating a String? | |||
There was a problem hiding this comment.
The client should probably have some sort of ActionType enum implemented instead of passing strings like this. Partially for the allocation cost, and partially to reduce the likelihood of typos.
ekump
reviewed
Sep 11, 2024
ekump
reviewed
Sep 11, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
==========================================
+ Coverage 73.05% 73.28% +0.23%
==========================================
Files 252 252
Lines 36093 36153 +60
==========================================
+ Hits 26366 26496 +130
+ Misses 9727 9657 -70
|
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
BenchmarksComparisonBenchmark execution time: 2024-09-17 18:39:54 Comparing candidate commit 5532b66 in PR branch Found 7 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics. scenario:credit_card/is_card_number/37828224631000521389798
scenario:credit_card/is_card_number_no_luhn/ 3782-8224-6310-005
scenario:credit_card/is_card_number_no_luhn/37828224631000521389798
scenario:normalization/normalize_trace/test_trace
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
BaselineOmitted due to size. |
bwoebi
force-pushed
the
andrew.glaude/dogstatsd-client
branch
from
ae5c14e
to
8fecb9a
Compare
|
Closing this PR in favor of this other branch where I split the implementation which is much simpler to read (at the cost of some code duplication) https://github.com/DataDog/libdatadog/pull/638/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.