Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[golang] Enable more RC tests #3068

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[golang] Enable more RC tests #3068

wants to merge 5 commits into from

Conversation

eliottness
Copy link
Contributor

Motivation

Changes

Enable more APPSEC_RUNTIME_ACTIVATION tests

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@eliottness
[golang] Enable more RC tests
ce45889 
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@eliottness
[golang] Enable more RC tests
6243799 
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@eliottness
[golang] fix API security go weblogs
982ad8b 
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@eliottness
ParseForm consuming the body is nasty
f64d8d6 
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@eliottness
restore test_schemas.py
52da47a 
Signed-off-by: Eliott Bouhana <eliott.bouhana@datadoghq.com>
@eliottness eliottness marked this pull request as ready for review September 18, 2024 20:58
@eliottness eliottness requested review from a team as code owners September 18, 2024 20:58
robertomonteromiguel
robertomonteromiguel requested changes Sep 19, 2024
View reviewed changes
Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are CI failures related with this PR

RomainMuller
RomainMuller approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@RomainMuller RomainMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this will only pass once DataDog/dd-trace-go#2878 is merged, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertomonteromiguel robertomonteromiguel robertomonteromiguel requested changes

@RomainMuller RomainMuller RomainMuller approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eliottness @RomainMuller @robertomonteromiguel