forked from dbt-labs/jaffle_shop_duckdb
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rounding Effect Analysis Feature #3
Open
even-wei
wants to merge
1
commit into
main
Choose a base branch
from
feature/add-rounding-effect-analysis
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentwelcome
force-pushed
the
feature/add-rounding-effect-analysis
branch
from
March 28, 2024 08:58
3422476
to
ea1949e
Compare
kentwelcome
force-pushed
the
feature/add-rounding-effect-analysis
branch
2 times, most recently
from
April 26, 2024 08:47
f77c882
to
dd81eee
Compare
Recce SummaryLineage Graphgraph LR
model.jaffle_shop.stg_payments["stg_payments [MODIFIED]"]
style model.jaffle_shop.stg_payments stroke:#ffa502
model.jaffle_shop.stg_payments---->model.jaffle_shop.customers
model.jaffle_shop.stg_payments---->model.jaffle_shop.orders
model.jaffle_shop.stg_payments-...->model.jaffle_shop.rounding_effect
model.jaffle_shop.customers["customers"]
model.jaffle_shop.customers---->model.jaffle_shop.customer_segments
model.jaffle_shop.customers---->model.jaffle_shop.customer_order_pattern
model.jaffle_shop.orders["orders"]
model.jaffle_shop.rounding_effect["rounding_effect [ADDED]"]
style model.jaffle_shop.rounding_effect stroke:#1dce00
model.jaffle_shop.customer_segments["customer_segments"]
model.jaffle_shop.customer_order_pattern["customer_order_pattern"]
Next StepsIf you want to check more detail inforamtion about the recce result, # Unzip the downloaded artifact file
tar -xf recce-state-file.zip
# Launch the recce server based on the state file
recce server --review recce_state.json |
popcornylu
force-pushed
the
feature/add-rounding-effect-analysis
branch
from
May 29, 2024 06:03
dd81eee
to
c3c7cbd
Compare
Recce SummaryLineage Graphgraph LR
model.jaffle_shop.stg_payments["stg_payments
[What's Changed]
Code, Schema"]
style model.jaffle_shop.stg_payments stroke:#ffa502
model.jaffle_shop.stg_payments---->model.jaffle_shop.orders
model.jaffle_shop.stg_payments---->model.jaffle_shop.customers
model.jaffle_shop.stg_payments-...->model.jaffle_shop.rounding_effect
model.jaffle_shop.orders["orders"]
model.jaffle_shop.customers["customers"]
model.jaffle_shop.customers---->model.jaffle_shop.customer_segments
model.jaffle_shop.customers---->model.jaffle_shop.customer_order_pattern
model.jaffle_shop.rounding_effect["rounding_effect
[What's Changed]
Added Node"]
style model.jaffle_shop.rounding_effect stroke:#1dce00
model.jaffle_shop.customer_segments["customer_segments"]
model.jaffle_shop.customer_order_pattern["customer_order_pattern"]
Checks Summary
Next StepsIf you want to check more detail inforamtion about the recce result, please download the artifact file and open it by Recce CLI. How to check the recce result# Unzip the downloaded artifact file
tar -xf recce-state-file.zip
# Launch the recce server based on the state file
recce server --review recce_state.json
# Open the recce server http://localhost:8000 by your browser |
popcornylu
force-pushed
the
feature/add-rounding-effect-analysis
branch
from
May 30, 2024 09:52
c3c7cbd
to
bfa3d74
Compare
Recce SummaryLineage Graphgraph LR
model.jaffle_shop.stg_payments["stg_payments
[What's Changed]
Code, Schema"]
style model.jaffle_shop.stg_payments stroke:#ffa502
model.jaffle_shop.stg_payments---->model.jaffle_shop.orders
model.jaffle_shop.stg_payments---->model.jaffle_shop.customers
model.jaffle_shop.stg_payments-...->model.jaffle_shop.rounding_effect
model.jaffle_shop.orders["orders"]
model.jaffle_shop.customers["customers"]
model.jaffle_shop.customers---->model.jaffle_shop.customer_segments
model.jaffle_shop.customers---->model.jaffle_shop.customer_order_pattern
model.jaffle_shop.rounding_effect["rounding_effect
[What's Changed]
Added Node"]
style model.jaffle_shop.rounding_effect stroke:#1dce00
model.jaffle_shop.customer_segments["customer_segments"]
model.jaffle_shop.customer_order_pattern["customer_order_pattern"]
Checks Summary
Next StepsIf you want to check more detail inforamtion about the recce result, please download the artifact file and open it by Recce CLI. How to check the recce result# Unzip the downloaded artifact file
tar -xf recce-state-file.zip
# Launch the recce server based on the state file
recce server --review recce_state.json
# Open the recce server http://localhost:8000 by your browser |
popcornylu
force-pushed
the
feature/add-rounding-effect-analysis
branch
from
June 5, 2024 08:23
bfa3d74
to
5eb597b
Compare
Recce SummaryLineage Graphgraph LR
model.jaffle_shop.stg_payments["stg_payments
[What's Changed]
Code, Schema"]
style model.jaffle_shop.stg_payments stroke:#ffa502
model.jaffle_shop.stg_payments---->model.jaffle_shop.orders
model.jaffle_shop.stg_payments---->model.jaffle_shop.customers
model.jaffle_shop.stg_payments-...->model.jaffle_shop.rounding_effect
model.jaffle_shop.orders["orders
[What's Changed]
"]
model.jaffle_shop.customers["customers
[What's Changed]
"]
model.jaffle_shop.customers---->model.jaffle_shop.customer_order_pattern
model.jaffle_shop.customers---->model.jaffle_shop.customer_segments
model.jaffle_shop.rounding_effect["rounding_effect
[What's Changed]
Added Node"]
style model.jaffle_shop.rounding_effect stroke:#1dce00
model.jaffle_shop.customer_order_pattern["customer_order_pattern"]
model.jaffle_shop.customer_segments["customer_segments"]
Checks Summary
Checks of Data Mismatch Detected
How to check the recce result# Launch the recce server based on the state file
recce server --review --cloud --password yummy_jaffle
# Open the recce server http://localhost:8000 by your browser |
kentwelcome
force-pushed
the
feature/add-rounding-effect-analysis
branch
2 times, most recently
from
June 6, 2024 18:31
13b9eea
to
48d079b
Compare
wcchang1115
force-pushed
the
feature/add-rounding-effect-analysis
branch
2 times, most recently
from
June 20, 2024 03:44
cbb7071
to
876790a
Compare
wcchang1115
force-pushed
the
feature/add-rounding-effect-analysis
branch
from
July 4, 2024 10:32
876790a
to
675f3f4
Compare
kentwelcome
force-pushed
the
feature/add-rounding-effect-analysis
branch
from
July 9, 2024 07:31
675f3f4
to
2f94dcb
Compare
wcchang1115
force-pushed
the
feature/add-rounding-effect-analysis
branch
2 times, most recently
from
August 14, 2024 02:10
675f3f4
to
2783f65
Compare
Signed-off-by: Even Wei <shinycockorach@gmail.com>
kentwelcome
force-pushed
the
feature/add-rounding-effect-analysis
branch
from
September 20, 2024 09:05
2783f65
to
ddba084
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This PR introduces a new Rounding Effect Analysis feature, aimed at analyzing and reporting the impacts of rounding in our data processing.
Changes:
Rationale:
To better understand and mitigate any potential distortions caused by data rounding.