Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme: Add warning about fake Proton-GE website that references ProtonUp-Qt #413

Merged
merged 3 commits into from
Jun 27, 2024

Conversation

sonic2kk
Copy link
Contributor

There is a fake website that has been around for a little while now claiming to be the website for GE-Proton. Most, if not all, of the content on the site is more than likely AI generated.

GloriousEggroll added a big disclaimer to the top of their Readme about it. However when visiting the site from the Readme I noticed that some pages actually reference ProtonUp-Qt. This means a user could miss the warning on the GE-Proton readme.

The warning at the moment is a bit "low key". I didn't want to do something quite as loud as what is on the GE-Proton repo, not because it isn't warranted, but just as a matter of organization. If you'd like a warning that loud though we can do it. Perhaps a "Note" / "Disclaimer" subheading to draw attention and putting this warning under it would be a good idea.

I also mentioned that other compatibility tools are not affiliated with this site, including GE-Proton.


We might also want to add the same warning to the Flatpak, once we settle on wording and visibility. While the site directs users on some pages to the repository it also mentions going to the Software Center Frontends, so putting the warning there as well means users are more likely to see it and become aware that the site is fake.

I don't really know what malicious things this site might do, but I think adding a note to the Readme to distance this project from it is a good idea. Although the other side of this is that we could end up drawing more attention to the site by doing this.

It is up to you whether we put this warning in, and how we format it. I just thought it would be good to get it out there that this site isn't affiliated with your project :-)

@DavidoTek
Copy link
Owner

DavidoTek commented Jun 23, 2024

Thanks for letting me know, I wasn't even aware that this site exists!

I don't think we should add a warning that specific, it only gives them more attention. What we can do, however, is to add a "generic" disclaimer regarding affiliation with other compatibility tools/websites.

What about:

Affiliation Note: ProtonUp-Qt is an independent tool for managing gaming compatibility tools. It is neither directly affiliated with the compatibility tool creators nor with the providers of the individual game launchers. However, we try to work with them where possible. The official development takes place at https://github.com/DavidoTek/ProtonUp-Qt and the official website is https://davidotek.github.io/protonup-qt/. We distribute ProtonUp-Qt on Flathub and as the AppImage in the releases section. Additionally, we check the integrity of the AUR and Pacstall distribution on an irregular basis.


At this point, should we give more credit to the services we are using? Use AreWeAntiCheatYet.com and ProtonDB.com for example. Maybe also the Steam API?

STEAM_API_GETAPPLIST_URL = 'https://api.steampowered.com/ISteamApps/GetAppList/v2/'
STEAM_APP_PAGE_URL = 'https://store.steampowered.com/app/'
AWACY_GAME_LIST_URL = 'https://raw.githubusercontent.com/Starz0r/AreWeAntiCheatYet/master/games.json'
AWACY_WEB_URL = 'https://areweanticheatyet.com/?search={GAMENAME}&sortOrder=&sortBy='
LOCAL_AWACY_GAME_LIST = os.path.join(TEMP_DIR, 'awacy_games.json')
PROTONDB_API_URL = 'https://www.protondb.com/api/v1/reports/summaries/{game_id}.json'
PROTONDB_APP_PAGE_URL = 'https://protondb.com/app/'

@sonic2kk
Copy link
Contributor Author

I think a more general note is a great idea, I didn't even consider that! We can also include that on the Flatpak page.

And indeed giving more credit to the services used is also a good idea.


The disclaimer you wrote is perfect imo, I will put that into the Readme. We could put that part under its own heading, a smaller one under the main section? I would normally suggest to put it just above the "Licensing" section, but that might hurt visibility.

Putting further credit to the services used could go above the Licensing section. Maybe an "Acknowledgements" section, although that might be a bit too formal :-)


I will push a commit with the changes mentioned and we can continue from there.

@sonic2kk
Copy link
Contributor Author

Pushed the changes, I didn't add the Steam API because it seems like the STEAM_API_GETAPPLIST_URL constant isn't actually used.

@DavidoTek DavidoTek merged commit 4683d5a into DavidoTek:main Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants