Mediation #219
Open
Mediation #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfultz
reviewed
Jan 15, 2019
| importFrom(DeclareDesign,redesign) | ||
| importFrom(DeclareDesign,set_diagnosands) | ||
| importFrom(DeclareDesign,tidy_estimator) | ||
| importFrom(broom,tidy) |
There was a problem hiding this comment.
pull in tidy from generics.
There was a problem hiding this comment.
thank for reviewing!
DESCRIPTION
Outdated
| @@ -27,7 +27,9 @@ Depends: | |||
| estimatr (>= 0.14.0) | |||
| Imports: | |||
| generics, | |||
| rlang | |||
| rlang, | |||
| mediation, | |||
There was a problem hiding this comment.
mediation should probably be a suggets and not an imports.
| mediator_regression + stage2_1 + stage2_2 + stage2_3 | ||
| ) | ||
|
|
||
| if(mediation_package){ |
There was a problem hiding this comment.
stopifnot(requireNamespace("mediation"))
R/mediation_analysis_designer.R
Outdated
| # QBA: Quasi-Bayesian Approximation | ||
| e1 <- lm(M ~ Z, data = data) | ||
| e2 <- lm(Y ~ M + Z + M:Z, data = data) | ||
| m <- mediate(e1, e2, sims = 100, treat = "Z", mediator = "M") |
There was a problem hiding this comment.
mediation::mediate and remove import
|
We're getting errror
|
|
PR has been merged, but it's not in the latest cran version, so not sure how generics handles that. When I include importFrom broom,tidy it seems to be working fine, but let me revise again. Sorry, this has been sitting here for so long! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
mediation_analysis_designer with Imai's package feature. Finally!
it needs GitHub's version of broom.
Checklist: