Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix fp in DL3006 & update to newer commit #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

swarnim-deepsource
Copy link

What I did

ensure we don't raise if image name is an arg

How I did it

names can't start with $

How to verify it

added a test, which fails if changes not present

jsoref and others added 5 commits February 20, 2023 09:54
* spelling: actually

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: encountered

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: filtered

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: github

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: gitlab

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: library

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: modules

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: multiple

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: official

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: omitted

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: respect

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: shellcheck

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: similarly

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: variable

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: without

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

---------

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
fix: misidentification of pipenv (hadolint#366)
ensure we don't raise if image name is an arg
@swarnim-deepsource swarnim-deepsource changed the title fix: fp in DL3006 chore: fix fp in DL3006 & update to newer commit May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants