Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation (v1.2.2) #118

Closed
Tosta-Mista opened this issue Apr 26, 2024 · 1 comment
Closed

Improve documentation (v1.2.2) #118

Tosta-Mista opened this issue Apr 26, 2024 · 1 comment
Assignees

Comments

@Tosta-Mista
Copy link

Hello,

I tried to follow your documentation, in order to install dsv-syncer and injector on a Kubernetes cluster (rke2). As we have our instance located in europe (tld = eu).

Unfortunately, in the documentation there's no example to change the TLD so I decided to add it in my PR.

I also got a patch error (on the syncer side) if I didn't add a dummy value in the secret data, so I also modified this part in the documentation.

Thank you for the work you do and I hope my PR is done properly.

Best regards,

@sheldonhull
Copy link
Contributor

fixed by 5e21066

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants