docs: improve docs on TLD info for connection #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheldonhull
changed the title
sheldonhull
requested changes
Jun 6, 2024
| @@ -26,6 +26,8 @@ The configuration requires a JSON formatted list of Client Credential and Tenant | |||
|
|
|||
| The name of the credential (such as `app1` or `default`) is used for matching the annontated credential to the right credentials file to use to connect to the connect tenant. | |||
|
|
|||
| By default, the `tld` is set to `.com` but you can change it by changing `tld` field to `eu` (for example: `"tld": "eu"`). | |||
There was a problem hiding this comment.
Suggested change
| By default, the `tld` is set to `.com` but you can change it by changing `tld` field to `eu` (for example: `"tld": "eu"`). | |
| If you have a different top level domain, for example `eu` instead of `.com` then look at the [section on supporting alternative tld for guidance](troubleshooting.md#supporting-alternative-tld). |
| @@ -37,7 +39,8 @@ You can place your temporary config in `.cache/credentials.json` as this is igno | |||
| "clientId": "", | |||
| "clientSecret": "xxxxxxxxxxxxxxxxxxxxxxxxx-xxxxxxxxxxx-xxxxx" | |||
| }, | |||
| "tenant": "mytenant" | |||
| "tenant": "mytenant", | |||
| "tld": "eu" | |||
There was a problem hiding this comment.
Can you revert the changes for the code sample since it's already included in the linked docs? Appreciate it!
|
to avoid delay/reworking, I went ahead and got the change in, so definitely appreciate bringing up that it wasn't clear enough. cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR to add new documentation examples.
Issue: #118