Add additional clauses/keywords to the insert statement #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthias-Q
reviewed
Mar 6, 2023
matthias-Q
reviewed
Mar 6, 2023
| @@ -948,18 +954,44 @@ module.exports = grammar({ | |||
| ), | |||
|
|
|||
| insert: $ => seq( | |||
| choice($.keyword_insert, $.keyword_replace), | |||
| $.keyword_into, | |||
There was a problem hiding this comment.
why is keyword_into now optional? For which dialect is this change?.
There was a problem hiding this comment.
MySQL does not require it - I thought it was always optional but apparently not. [1] is the MySQL reference
SQL Server does not require it either it appears [2]
[1] - https://dev.mysql.com/doc/refman/8.0/en/insert.html
[2] - https://learn.microsoft.com/en-us/sql/t-sql/statements/insert-transact-sql?view=sql-server-ver16
There was a problem hiding this comment.
Ah yes. Before your PR the grammar required an INTO keyword, but it looks like it is optional in MySQL and MariaDB as well.
wishdev
force-pushed
the
insert_improvements
branch
from
57cb35f
to
de17c23
Compare
wishdev
force-pushed
the
insert_improvements
branch
from
de17c23
to
080c9f1
Compare
DerekStride
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.