Pass through HTTP 429 to the nix daemon #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tried to see if there was a source for the current behavior, but the only source appears to be commit f698478 by @zhaofengli |
|
I did consider whether the |
philiptaron
approved these changes
Nov 28, 2023
edolstra
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the README / #17 documents that 429 is known to cause a substitution error, I've not found any reason why this error can't be passed through to the nix-daemon so it will attempt to retry the substitution after a delay rather than completely disabling the cache.
The nix daemon even has specific behavior for this case: https://github.com/NixOS/nix/blob/df9bd755a115ecdcdf6566c39167aad3d1b08da2/src/libstore/filetransfer.cc#L415