convert unwraps to expects #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colemickens
force-pushed
the
colemickens/unwraps-to-expect
branch
from
e154491
to
012d38c
Compare
colemickens
commented
Aug 29, 2024
magic-nix-cache/src/gha.rs
Outdated
Comment on lines
230
to
238
| r.file_name() | ||
| .and_then(|n| n.to_str()) | ||
| .unwrap_or_else(|| panic!("failed to convert nar_info reference to string: {}", | ||
| r.display())) | ||
| .to_owned() |
There was a problem hiding this comment.
this seems like somewhere we might want to surface out an error, maybe MNC should just warn + skip the path?
Maybe that's worse though, it'd be annoying to debug a case where 99% of a closure is uploaded but a ref is missing. Maybe Nix will give an okay message in that case.
There was a problem hiding this comment.
but not right now :)
colemickens
force-pushed
the
colemickens/unwraps-to-expect
branch
from
012d38c
to
fa02e9a
Compare
grahamc
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is every
unwrap(replaced with an expect. The expect usages seem fine to me.