This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Duplicate 'dema' section in readme #1064
Labels
Comments
|
That is actually My suggested fix is to rename it there and rename it in the list-strategies README as well. We can remove it now but it is one of the strats so it'll be back as soon as we add another strategy and update the output. |
|
+1 for rename |
|
looking further, yes, leaving it there and renaming would be easiest, but ideally, this would be integrated with the existing strategy since it's basically the same thing just with the added option of a null signal. |
|
i have added a pr to merge both strategies. |
DeviaVir
added a commit
that referenced
this issue
Jan 7, 2018
* bring the recent commits to master down into unstable (#1048) * update products.json file to newest trading pairs at binance (#1028) * Binance changed API 24 hours to 1 hour (#1027) * Update README * Update README again * add generation data to gitignore (#1012) * binance changed their API strategy from 24 hour windows to 1 hour. * rename periodLength to period_length (#1035) * Change markup_pct to new markdown and markup, set commonArgs so it is included in all strategies, fix return. (#1047) The only other occurrence is in the readme file noting the legacy aspect. * Update darwin.js * Added support for dema-strategy to darwin.js (#1046) * fix bad escaping on output to console (#1045) * Update periodLength to underscore syntax for darwin * Missing | lead to bitwise operation being performed rather than an OR logical comparison. (#1053) * Console Output adjustment (#1055) * resolution to .csv & .json output (#1058) * resolution to .csv & .json output trogdor123 got me looking at the right section where the params were being input in json. made some minor tweaks to the code and now both are outputting correctly. * Update darwin.js ...changes - formatting. * darwin.js - crossover strategy (#1060) noticed that generational output was static from gen to gen for smalen1 and smalen2. sure enough, those are coded into the strategy itself, but were left out of the darwin.js strategy config for mutation. * Docker (#1061) * docker fix * Resolve docker build problems * noop strategy: readme/links/list (#1062) * Travis. Docker. (#1063) * Updated minimum required node version (#1066) It appears Zenbot wont work on anything before 8.3.0. Updating the minimum required version, for clarity. * Merge DemaStrats (#1067) fixes #1064 * v4.1.0: prepare release (#1068) * v4.1.0: prepare release * update package-lock.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
dema section was duplicated in commit e8fc526 starting at line 318 of README.md
The text was updated successfully, but these errors were encountered: