Bittrex Exchange #1215
Bittrex Exchange #1215
Conversation
* Fix SRSI calculation * Added test case for SRSI. Switched RSI and SRSI output to float and adjusted display accordingly * Oops, disabled all other tests by mistake * Fix test assertion
This fixes the error `/usr/bin/env: ‘node\r’: No such file or directory`
Report is now able to display values less than 1. space limited to 7 characters per column so smallest value is 0.00001
Updated bittrex api from node.bittrex.api -> node-bittrex-api node.bittrex.api is no longer maintained Added some error handling so exchange is now passing back useful errors to the engine. i.e. it will no longer keep retrying a buy sell order if there isn’t enough funds. socket errors no longer crash the system but passed to the retry handler.
| var bittrex_authed = require('node-bittrex-api'), | ||
| bittrex_public = require('node-bittrex-api'), | ||
| moment = require('moment'), | ||
| n = require('numbro') |
There was a problem hiding this comment.
It is formatted according the the setting in .eslintrc.
I'll manually format it.
| moment = require('moment'), | ||
| n = require('numbro'), | ||
| colors = require('colors') | ||
| var bittrex_authed = require('node-bittrex-api'), |
There was a problem hiding this comment.
Should historyScan still be forward?
https://github.com/DeviaVir/zenbot/pull/1215/files#diff-b3b56e634e6ef011a9923a3c54c40108L51
There was a problem hiding this comment.
Unsure. The market history on bittrex is very limited. It will pull only the last couple of trades. there is a workaround that someone came up with using the v2 api that seems to get around this limitation, I'll look at implementing it. hate having to leave a marking noop trading for days to get a decent history on.
There was a problem hiding this comment.
I just double checked this moving to forward causes
on markets I already have data on
error: getTrades() returned duplicate results
{ product_id: 'XRP-USDT', to: 1516785694047 }
{ product_id: 'XRP-USDT', to: 1516785694047 }
it returns nothing on markets I don't have data on.
So for now, I think it should remain as backward until I can looking into the history calls in bittrex.
| if(!data.success) { | ||
| if (data.message && data.message.match(recoverableErrors)) { | ||
| if ( data.message && data.message.match(recoverableErrors)) { |
|
will correct in a few. |
|
@DeviaVir, it looks like I got all the corrections for formatting. The history part is just broken due to the api, and the way bittrex returns market data. I would also like to convert this to using websockets but that is for a later date. |
|
SGTM I will merge this now so we can look at the other additions fresh. |
Correction for #1211, #1170, #1164
Updated bittrex api from node.bittrex.api -> node-bittrex-api
node.bittrex.api is no longer maintained
Added some error handling so exchange is now passing back useful errors
to the engine.
i.e. it will no longer keep retrying a buy sell order if there isn’t
enough funds.
socket errors no longer crash the system but passed to the retry
handler.
npm must be updated.
npm install node-bittrex-api
After these corrections it eliminated the errors cited in #1211.
Unintentional corrections: (I like these :)
Errors now passed back to engine.js for proper handling
Orders will now readjust price ( old versions was silently failing )