Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

FIxing kraken product update and product list #483

Merged
merged 2 commits into from
Aug 27, 2017
Merged

FIxing kraken product update and product list #483

merged 2 commits into from
Aug 27, 2017

Conversation

cmroche
Copy link
Contributor

@cmroche cmroche commented Aug 17, 2017

Adds a check for the known broken currencies

@cmroche
Copy link
Contributor Author

cmroche commented Aug 17, 2017

Fixes bug #427

@timstoop
Copy link

Tested this locally, but it only fixes part of the problem. With this patch applied and running balance kraken.BCH-EUR, it does not recognise the EUR I have in my account.

@cmroche
Copy link
Contributor Author

cmroche commented Aug 24, 2017

Ok, thanks for the feedback. I should be able to devise a solution.

Also update products as kraken recently delisted some pairs.
@cmroche
Copy link
Contributor Author

cmroche commented Aug 25, 2017

@timstoop Try applying the change again, should work now.

@cmroche cmroche closed this Aug 25, 2017
@cmroche cmroche reopened this Aug 25, 2017
@timstoop
Copy link

balance works, backfill works and trade --paper works! Great stuff!

@DeviaVir DeviaVir merged commit dc7c089 into DeviaVir:master Aug 27, 2017
@cmroche cmroche deleted the kraken_fixes branch August 27, 2017 18:07
supersabbath pushed a commit to supersabbath/zenbot that referenced this pull request Oct 2, 2017
* Fixing kraken product update and product list

* Fix for Kraken's inconsistent approach to currency

Also update products as kraken recently delisted some pairs.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants