Skip to content

Commit

Permalink
Fix instrumentation tests not working via Gradle
Browse files Browse the repository at this point in the history
PiperOrigin-RevId: 475560401
  • Loading branch information
rohitjoins authored and marcbaechinger committed Oct 19, 2022
1 parent fd6b0d1 commit 6015f05
Show file tree
Hide file tree
Showing 17 changed files with 20 additions and 19 deletions.
2 changes: 1 addition & 1 deletion extensions/cronet/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ dependencies {
compileOnly 'com.google.errorprone:error_prone_annotations:' + errorProneVersion
compileOnly 'org.checkerframework:checker-qual:' + checkerframeworkVersion
compileOnly 'org.jetbrains.kotlin:kotlin-annotations-jvm:' + kotlinAnnotationsVersion
androidTestImplementation 'androidx.multidex:multidex:' + androidxMultidexVersion
androidTestImplementation 'androidx.test:rules:' + androidxTestRulesVersion
androidTestImplementation 'androidx.test:runner:' + androidxTestRunnerVersion
androidTestImplementation 'androidx.multidex:multidex:' + androidxMultidexVersion
androidTestImplementation 'com.linkedin.dexmaker:dexmaker-mockito:' + dexmakerVersion
// Instrumentation tests assume that an app-packaged version of cronet is
// available.
Expand Down
3 changes: 1 addition & 2 deletions extensions/cronet/src/androidTest/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
<uses-sdk/>

<!-- TODO(b/243799715): Use android:name="androidx.multidex.MultiDexApplication" instead. -->
<application
android:name="android.support.multidex.MultiDexApplication"
android:name="androidx.multidex.MultiDexApplication"
android:allowBackup="false"
android:usesCleartextTraffic="true"
tools:ignore="MissingApplicationIcon,HardcodedDebugMode"/>
Expand Down
4 changes: 4 additions & 0 deletions extensions/flac/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@
apply from: "$gradle.ext.exoplayerSettingsDir/common_library_config.gradle"

android {
defaultConfig {
multiDexEnabled true
}
sourceSets {
main {
jniLibs.srcDir 'src/main/libs'
Expand All @@ -31,6 +34,7 @@ dependencies {
compileOnly 'org.checkerframework:checker-qual:' + checkerframeworkVersion
compileOnly 'org.jetbrains.kotlin:kotlin-annotations-jvm:' + kotlinAnnotationsVersion
androidTestImplementation project(modulePrefix + 'testutils')
androidTestImplementation 'androidx.multidex:multidex:' + androidxMultidexVersion
androidTestImplementation 'androidx.test:runner:' + androidxTestRunnerVersion
testImplementation 'androidx.test:core:' + androidxTestCoreVersion
testImplementation 'androidx.test.ext:junit:' + androidxTestJUnitVersion
Expand Down
3 changes: 1 addition & 2 deletions extensions/flac/src/androidTest/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
<uses-sdk/>

<!-- TODO(b/243799715): Use android:name="androidx.multidex.MultiDexApplication" instead. -->
<application
android:name="android.support.multidex.MultiDexApplication"
android:name="androidx.multidex.MultiDexApplication"
android:allowBackup="false"
tools:ignore="MissingApplicationIcon,HardcodedDebugMode"/>

Expand Down
3 changes: 1 addition & 2 deletions extensions/ima/src/androidTest/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,8 @@
<uses-permission android:name="android.permission.WAKE_LOCK"/>
<uses-sdk/>

<!-- TODO(b/243799715): Use android:name="androidx.multidex.MultiDexApplication" instead. -->
<application
android:name="android.support.multidex.MultiDexApplication"
android:name="androidx.multidex.MultiDexApplication"
android:allowBackup="false"
tools:ignore="MissingApplicationIcon,HardcodedDebugMode">
<activity android:name="com.google.android.exoplayer2.testutil.HostActivity"
Expand Down
1 change: 1 addition & 0 deletions extensions/media2/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ dependencies {
compileOnly 'org.checkerframework:checker-qual:' + checkerframeworkVersion
compileOnly 'org.jetbrains.kotlin:kotlin-annotations-jvm:' + kotlinAnnotationsVersion
androidTestImplementation project(modulePrefix + 'library-core')
androidTestImplementation 'androidx.multidex:multidex:' + androidxMultidexVersion
androidTestImplementation 'androidx.test.ext:junit:' + androidxTestJUnitVersion
androidTestImplementation 'androidx.test:core:' + androidxTestCoreVersion
androidTestImplementation 'androidx.test:runner:' + androidxTestRunnerVersion
Expand Down
3 changes: 1 addition & 2 deletions extensions/media2/src/androidTest/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
<uses-sdk/>

<!-- TODO(b/243799715): Use android:name="androidx.multidex.MultiDexApplication" instead. -->
<application
android:name="android.support.multidex.MultiDexApplication"
android:name="androidx.multidex.MultiDexApplication"
android:allowBackup="false"
tools:ignore="MissingApplicationIcon,HardcodedDebugMode"/>

Expand Down
1 change: 1 addition & 0 deletions extensions/opus/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ dependencies {
compileOnly 'org.jetbrains.kotlin:kotlin-annotations-jvm:' + kotlinAnnotationsVersion
testImplementation project(modulePrefix + 'testutils')
testImplementation 'org.robolectric:robolectric:' + robolectricVersion
androidTestImplementation 'androidx.multidex:multidex:' + androidxMultidexVersion
androidTestImplementation 'androidx.test:runner:' + androidxTestRunnerVersion
androidTestImplementation 'androidx.test.ext:junit:' + androidxTestJUnitVersion
}
Expand Down
3 changes: 1 addition & 2 deletions extensions/opus/src/androidTest/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
<uses-sdk/>

<!-- TODO(b/243799715): Use android:name="androidx.multidex.MultiDexApplication" instead. -->
<application
android:name="android.support.multidex.MultiDexApplication"
android:name="androidx.multidex.MultiDexApplication"
android:allowBackup="false"
tools:ignore="MissingApplicationIcon,HardcodedDebugMode"/>

Expand Down
1 change: 1 addition & 0 deletions extensions/vp9/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ dependencies {
compileOnly 'org.jetbrains.kotlin:kotlin-annotations-jvm:' + kotlinAnnotationsVersion
testImplementation project(modulePrefix + 'testutils')
testImplementation 'org.robolectric:robolectric:' + robolectricVersion
androidTestImplementation 'androidx.multidex:multidex:' + androidxMultidexVersion
androidTestImplementation 'androidx.test:runner:' + androidxTestRunnerVersion
androidTestImplementation 'androidx.test.ext:junit:' + androidxTestJUnitVersion
androidTestImplementation 'com.google.truth:truth:' + truthVersion
Expand Down
3 changes: 1 addition & 2 deletions extensions/vp9/src/androidTest/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>
<uses-sdk/>

<!-- TODO(b/243799715): Use android:name="androidx.multidex.MultiDexApplication" instead. -->
<application
android:name="android.support.multidex.MultiDexApplication"
android:name="androidx.multidex.MultiDexApplication"
android:allowBackup="false"
tools:ignore="MissingApplicationIcon,HardcodedDebugMode"/>

Expand Down
1 change: 1 addition & 0 deletions library/core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ dependencies {
compileOnly 'org.checkerframework:checker-compat-qual:' + checkerframeworkCompatVersion
compileOnly 'org.jetbrains.kotlin:kotlin-annotations-jvm:' + kotlinAnnotationsVersion
compileOnly 'com.google.errorprone:error_prone_annotations:' + errorProneVersion
androidTestImplementation 'androidx.multidex:multidex:' + androidxMultidexVersion
androidTestImplementation 'androidx.test:runner:' + androidxTestRunnerVersion
androidTestImplementation 'com.linkedin.dexmaker:dexmaker:' + dexmakerVersion
androidTestImplementation 'com.linkedin.dexmaker:dexmaker-mockito:' + dexmakerVersion
Expand Down
3 changes: 1 addition & 2 deletions library/core/src/androidTest/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@
<uses-permission android:name="android.permission.INTERNET"/>
<uses-sdk/>

<!-- TODO(b/243799715): Use android:name="androidx.multidex.MultiDexApplication" instead. -->
<application
android:name="android.support.multidex.MultiDexApplication"
android:name="androidx.multidex.MultiDexApplication"
android:allowBackup="false"
tools:ignore="MissingApplicationIcon,HardcodedDebugMode"
android:usesCleartextTraffic="true"/>
Expand Down
1 change: 1 addition & 0 deletions library/datasource/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ dependencies {
compileOnly 'org.checkerframework:checker-compat-qual:' + checkerframeworkCompatVersion
compileOnly 'org.checkerframework:checker-qual:' + checkerframeworkVersion
compileOnly 'org.jetbrains.kotlin:kotlin-annotations-jvm:' + kotlinAnnotationsVersion
androidTestImplementation 'androidx.multidex:multidex:' + androidxMultidexVersion
androidTestImplementation 'androidx.test:runner:' + androidxTestRunnerVersion
androidTestImplementation 'com.linkedin.dexmaker:dexmaker:' + dexmakerVersion
androidTestImplementation 'com.linkedin.dexmaker:dexmaker-mockito:' + dexmakerVersion
Expand Down
3 changes: 1 addition & 2 deletions library/datasource/src/androidTest/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,8 @@
<uses-permission android:name="android.permission.INTERNET"/>
<uses-sdk/>

<!-- TODO(b/243799715): Use android:name="androidx.multidex.MultiDexApplication" instead. -->
<application
android:name="android.support.multidex.MultiDexApplication"
android:name="androidx.multidex.MultiDexApplication"
android:allowBackup="false"
android:usesCleartextTraffic="true"
tools:ignore="MissingApplicationIcon,HardcodedDebugMode">
Expand Down
1 change: 1 addition & 0 deletions playbacktests/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ android {
}

dependencies {
androidTestImplementation 'androidx.multidex:multidex:' + androidxMultidexVersion
androidTestImplementation 'androidx.test:rules:' + androidxTestRulesVersion
androidTestImplementation 'androidx.test:runner:' + androidxTestRunnerVersion
androidTestImplementation 'androidx.annotation:annotation:' + androidxAnnotationVersion
Expand Down
3 changes: 1 addition & 2 deletions playbacktests/src/androidTest/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,8 @@
<uses-permission android:name="android.permission.WAKE_LOCK"/>
<uses-sdk/>

<!-- TODO(b/243799715): Use android:name="androidx.multidex.MultiDexApplication" instead. -->
<application
android:name="android.support.multidex.MultiDexApplication"
android:name="androidx.multidex.MultiDexApplication"
android:allowBackup="false"
tools:ignore="MissingApplicationIcon,HardcodedDebugMode">
<activity android:name="com.google.android.exoplayer2.testutil.HostActivity"
Expand Down

0 comments on commit 6015f05

Please sign in to comment.