Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support minimizing floating windows independently of main window #276

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

mpondo
Copy link
Contributor

@mpondo mpondo commented May 31, 2021

The current behavior treats all the windows as a group. Minimizing the main window will cause all the floating windows to be minimized. Also, if you minimize a floating window, it is minimized but then is immediately restored.

Our users requested that the they have the ability to minimize the windows independently. This is because they may need to minimize a single window that is in the way of another window, but they do not necessarily want to minimize all the other windows for the app.

In order to support this, this change adds 2 properties to the LayoutFloatingWindowControl:

  • AllowMinimize which determines whether a floating window can be minimized. Setting this to 'true' enables the ability to minimize the floating window while leaving the main window as it is.
  • OwnedByDockingManagerWindow which determines whether the window is "owned" by the main window. This determines whether the floating window should automatically minimize when the main window does or whether it should be left as is.

By separating it into 2 properties, developers have more control based on their specific needs.

The default value for each property is set to leave the current behavior unchanged.

@Dirkster99 Dirkster99 merged commit 22e6ec6 into Dirkster99:master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants