Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added description about ssh keys #11

Merged
merged 1 commit into from
Jul 6, 2014

Conversation

lukaszb
Copy link
Contributor

@lukaszb lukaszb commented Jul 3, 2014

No description provided.

@olasitarska
Copy link
Member

I think I know why I didn't do this part. I think Heroku toolbelt is doing that for us while authenticating: https://toolbelt.heroku.com/
Do you think it's going to be enough?:)

@olasitarska
Copy link
Member

hi there @lukaszb?:) what do you think?

@lukaszb
Copy link
Contributor Author

lukaszb commented Jul 6, 2014

Yeah, makes no sense to add extra info in case it's not needed. I'm not sure if they had included ssh key generation recently (doubt it) or we had some troubles to make it working on Windows on last Django Carrots edition. Either way, I think it would be good to include information that SSH keys would be created when invoking heroku login command. Would change PR accordingly and let you decide if it is worth including (in my opinion it would be better to have this noted as otherwise in case of missing ssh-keygen coaches/attendees might go look for solution to the wrong problem - i.e. on Windows it might be a matter of updating PATH env var instead of looking for ssh keygen built).

@lukaszb lukaszb changed the title Added description of how to register ssh keys at osx Added description about ssh keys Jul 6, 2014
@olasitarska
Copy link
Member

@lukaszb make sense, thanks!

olasitarska added a commit that referenced this pull request Jul 6, 2014
Added description about ssh keys
@olasitarska olasitarska merged commit 5fb3d7a into DjangoGirls:master Jul 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants