Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes from notes #14

Merged
merged 8 commits into from
Jul 5, 2014
Merged

Conversation

bmispelon
Copy link
Contributor

As promised, here's the list of things changed by this pull request (there's roughly one commit per item to make reviewing easier):

  • some links to python docs point to version 2
  • in install_python, the python3 version should be 3.4.1?
  • in django_models, default=timezone.now() should be timezone.now
  • __unicode__ should be __str__ (Python 3)
  • in deploy, the .gitignore file should ignore __pycache__ (python 3) instead of *.pyc (python 2)
  • Links to Django docs should point to the version used (1.6)
  • in django_forms, there's no need for the {% load future %}
  • in django_forms, we could use shortcuts.redirect() instead of HttpResponseRedirect
  • in domain, the google search link can be simplified (and moved to google.com instead of google.pl probably)

@keimlink
Copy link
Contributor

keimlink commented Jul 5, 2014

All changes are looking good!

olasitarska added a commit that referenced this pull request Jul 5, 2014
@olasitarska olasitarska merged commit 1d6c75d into DjangoGirls:master Jul 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants