Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment needs a persistent database #158

Merged
merged 4 commits into from
Nov 5, 2014
Merged

Deployment needs a persistent database #158

merged 4 commits into from
Nov 5, 2014

Conversation

goranche
Copy link
Contributor

Added instructions for PostgreSQL database creation in the deploy chapter (Heroku no longer creates a default database when creating an application)

@goranche
Copy link
Contributor Author

oh... serves me right for not checking other PRs first 😊
this is a "duplicate" of #146


$ heroku addons:add heroku -postgresql --app djangogirlsblog

> In addition to creating a database for us, Heroku will also provide our application information on how to connect to the database. This information will be read and used by `dj_database_url.config()` in our `mysite/settings.py file`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this wrong? Heroku won't create a db for us, as you stated below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running this command will create it on Heroku... might have stated that differently, I agree
changed, thanks 😉

@syndbg
Copy link
Contributor

syndbg commented Oct 31, 2014

I personally like this extra info compared to #146.

👍

@goranche
Copy link
Contributor Author

thanks 👍

@domenkozar
Copy link
Contributor

+1

olasitarska added a commit that referenced this pull request Nov 5, 2014
Deployment needs a persistent database
@olasitarska olasitarska merged commit f2baefc into DjangoGirls:master Nov 5, 2014
@olasitarska
Copy link
Member

Thanks for the contribution @goranche! <3

@goranche
Copy link
Contributor Author

goranche commented Nov 7, 2014

glad to help 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants