Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Node version to 6.10.0 #819

Merged
merged 1 commit into from
Mar 14, 2017
Merged

Pin Node version to 6.10.0 #819

merged 1 commit into from
Mar 14, 2017

Conversation

aaronschachter
Copy link
Contributor

@aaronschachter aaronschachter commented Mar 14, 2017

What's this PR do?

Pins Node version to 6.10. We were previously always using the latest version of Node 🤦‍♀️

How should this be reviewed?

Deploy to heroku and confirm the build logs look like this:

-----> Installing binaries
       engines.node (package.json):  6.10.x
       engines.npm (package.json):   unspecified (use default)
       
       Resolving node version 6.10.x via semver.io...
       Downloading and installing node 6.10.0...
       Using default npm version: 3.10.10
-----> Restoring cache

Instead of this:

-----> Installing binaries
       engines.node (package.json):  >=6.10.x
       engines.npm (package.json):   unspecified (use default)
       
       Resolving node version >=6.10.x via semver.io...
       Downloading and installing node 7.7.2...

Any background context you want to provide?

This should close out #811 if Node 7.7.2 is the culprit as suggested in https://github.com/DoSomething/gambit/issues/811#issuecomment-285753435

Relevant tickets

Fixes #811

Checklist

  • Tested on staging.

@aaronschachter aaronschachter temporarily deployed to ds-mdata-responder-staging March 14, 2017 17:09 Inactive
@aaronschachter aaronschachter merged commit 2b382d4 into develop Mar 14, 2017
@aaronschachter aaronschachter deleted the 6.10 branch March 14, 2017 17:12
Copy link
Contributor

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants