Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete respect dropdownOptions. Fix placement when container is… #6602

Open
wants to merge 2 commits into
base: v1-dev
Choose a base branch
from
Open

Autocomplete respect dropdownOptions. Fix placement when container is… #6602

wants to merge 2 commits into from

Conversation

daniel-nelson
Copy link

@daniel-nelson daniel-nelson commented Sep 21, 2020

… document.body

Proposed changes

Autocomplete should pass dropdownOptions to the dropdown. As described in #1385, Dropdown options can be used to customize the container used by Dropdown. Autocomplete is built on Dropdown, so should pass Dropdown options.

Our specific need for this is so that Autocomplete options don't get cut off within a modal.

Screenshots (if appropriate) or codepen:

Current v1.0.0 behavior:
Screen Shot 2020-09-21 at 4 24 28 PM

With these changes, we can specify dropdownOptions: { container: document.body }, and get:
Screen Shot 2020-09-21 at 4 18 35 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant