Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add userDismissible option for toasts #6666

Open
wants to merge 1 commit into
base: v1-dev
Choose a base branch
from

Conversation

EliasBinder
Copy link

Proposed changes

Introduced an additional option for toasts to allow them only to be dismissed programmatically and not by swiping. However, this option defaults to true, so there are no behaviour changes regarding the current version in case this option is omitted in M.toast({...}).

This can be useful for several cases:

  • when a preloader bar is included in a toast to show the progress of an async file upload.
  • when the user is offline. The toast can then be dismissed as soon as connectivity is restored.
    ...

Screenshots (if appropriate) or codepen:

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Introduced an additional option for toasts to allow them only to be
dismissed programmatically and not by swiping.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants