Fixes nose run test on test case #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did they ever pass? |
|
@efremovd |
|
@DonJayamanne will do later today. Thank you. |
|
@DonJayamanne I resolved conflicts, please review. Thank you. |
DonJayamanne
added a commit
that referenced
this pull request
Apr 4, 2018
#1225) * split compilation for faster compilation on windows * 🔨 rename linting (else auto fix is not available) [skip ci] * ✅ tests * Fixes #1143 * Also updated debugger (npm) packages.
Goom11
pushed a commit
to mostafaeweda/pythonVSCode
that referenced
this pull request
Aug 30, 2018
DonJayamanne#1225) * split compilation for faster compilation on windows * 🔨 rename linting (else auto fix is not available) [skip ci] * ✅ tests * Fixes #1143 * Also updated debugger (npm) packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First, thank you for your awesome work.
Fixes #597
I went through doc for nose and looks like test should be run as
<file_name>:<class name>so I fixed nameToRun to have such syntax.