Integration tests pass

DrSOKane · Jul 31, 2023 · 6e5886a · 6e5886a
1 parent a859d12
commit 6e5886a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/...test_models/test_full_battery_models/test_lithium_ion/base_lithium_ion_half_cell_tests.py b/...test_models/test_full_battery_models/test_lithium_ion/base_lithium_ion_half_cell_tests.py
@@ -50,8 +50,9 @@ def test_irreversible_plating_with_porosity(self):
             "lithium plating": "irreversible",
             "lithium plating porosity change": "true",
         }
-        param = pybamm.ParameterValues("OKane2022_negative_halfcell")
-        self.run_basic_processing_test(options, parameter_values=param)
+        parameter_values = pybamm.ParameterValues("OKane2022_negative_halfcell")
+        parameter_values.update({"Current function [A]": -2.5})  # C/2 charge
+        self.run_basic_processing_test(options, parameter_values=parameter_values)
 
     def test_sei_constant(self):
         options = {"SEI": "constant"}
@@ -65,7 +66,7 @@ def test_sei_asymmetric_reaction_limited(self):
         options = {"SEI": "reaction limited (asymmetric)"}
         parameter_values = pybamm.ParameterValues("Ecker2015_graphite_halfcell")
         parameter_values.update(
-            {"SEI growth transfer coefficient": 0.2},
+            {"SEI growth transfer coefficient": 0.2, "Current function [A]": -0.07826},
             check_already_exists=False,
         )
         self.run_basic_processing_test(options, parameter_values=parameter_values)
@@ -90,14 +91,15 @@ def test_sei_asymmetric_ec_reaction_limited(self):
         options = {"SEI": "ec reaction limited (asymmetric)"}
         parameter_values = pybamm.ParameterValues("Ecker2015_graphite_halfcell")
         parameter_values.update(
-            {"SEI growth transfer coefficient": 0.2},
+            {"SEI growth transfer coefficient": 0.2, "Current function [A]": -0.07826},
             check_already_exists=False,
         )
         self.run_basic_processing_test(options, parameter_values=parameter_values)
 
     def test_swelling_only(self):
         options = {"particle mechanics": "swelling only"}
         parameter_values = pybamm.ParameterValues("OKane2022_negative_halfcell")
+        parameter_values.update({"Current function [A]": -2.5})  # C/2 charge
         self.run_basic_processing_test(options, parameter_values=parameter_values)
 
     def test_constant_utilisation(self):

diff --git a/...tion/test_models/test_full_battery_models/test_lithium_ion/test_basic_half_cell_models.py b/...tion/test_models/test_full_battery_models/test_lithium_ion/test_basic_half_cell_models.py
@@ -38,7 +38,7 @@ def test_runs_Xu2019(self):
         solver = pybamm.CasadiSolver(mode="safe", atol=1e-6, rtol=1e-3)
         solver.solve(model, t_eval)
 
-    def test_runs_OKane2022(self):
+    def test_runs_OKane2022_negative(self):
         # load model
         options = {"half-cell": "true"}
         model = pybamm.lithium_ion.BasicDFNHalfCell(options=options)
@@ -47,9 +47,9 @@ def test_runs_OKane2022(self):
         geometry = model.default_geometry
 
         # load parameter values
-        param = pybamm.ParameterValues("OKane2022")
+        param = pybamm.ParameterValues("OKane2022_negative_halfcell")
 
-        param["Current function [A]"] = 2.5
+        param["Current function [A]"] = -2.5  # C/2 charge
 
         # process model and geometry
         param.process_model(model)