Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: execute #2

Merged
merged 2 commits into from
Nov 1, 2023
Merged

fix: execute #2

merged 2 commits into from
Nov 1, 2023

Conversation

danteay
Copy link
Contributor

@danteay danteay commented Nov 1, 2023

Description

ejson binary is removed from source and is now downloaded by the docker file

Task Context

What is the current behavior?

  • ejson binary was part of the source code and was added on docker as a file
  • the error output from exec command was ommited and never gave feedback about errors

What is the new behavior?

  • ejson binary is now downloaded by docker configuration
  • the execution errors was now checked and if there are errors are returned as exceptions

Additional Context

@danteay danteay merged commit dd535f0 into main Nov 1, 2023
2 checks passed
@danteay danteay deleted the fix/execute branch November 1, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danteay