Skip to content

Commit

Permalink
add compile-fail test for &mut promotion
Browse files Browse the repository at this point in the history
  • Loading branch information
RalfJung committed Sep 6, 2020
1 parent 720293b commit 28ddda7
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 1 deletion.
10 changes: 10 additions & 0 deletions src/test/ui/consts/promote-no-mut.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// ignore-tidy-linelength
// We do not promote mutable references.
static mut TEST1: Option<&mut [i32]> = Some(&mut [1, 2, 3]); //~ ERROR temporary value dropped while borrowed

static mut TEST2: &'static mut [i32] = {
let x = &mut [1,2,3]; //~ ERROR temporary value dropped while borrowed
x
};

fn main() {}
23 changes: 23 additions & 0 deletions src/test/ui/consts/promote-no-mut.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
error[E0716]: temporary value dropped while borrowed
--> $DIR/promote-no-mut.rs:3:50
|
LL | static mut TEST1: Option<&mut [i32]> = Some(&mut [1, 2, 3]);
| ----------^^^^^^^^^-
| | | |
| | | temporary value is freed at the end of this statement
| | creates a temporary which is freed while still in use
| using this value as a static requires that borrow lasts for `'static`

error[E0716]: temporary value dropped while borrowed
--> $DIR/promote-no-mut.rs:6:18
|
LL | let x = &mut [1,2,3];
| ^^^^^^^ creates a temporary which is freed while still in use
LL | x
| - using this value as a static requires that borrow lasts for `'static`
LL | };
| - temporary value is freed at the end of this statement

error: aborting due to 2 previous errors

For more information about this error, try `rustc --explain E0716`.
2 changes: 1 addition & 1 deletion src/test/ui/consts/promotion-mutable-ref.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#![feature(const_mut_refs)]

static mut TEST: i32 = {
// We cannot promote this, as CTFE needs to be able to mutate it later.
// We must not promote this, as CTFE needs to be able to mutate it later.
let x = &mut [1,2,3];
x[0] += 1;
x[0]
Expand Down

0 comments on commit 28ddda7

Please sign in to comment.