export the test methods #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdimatteo
force-pushed
the
exports-test-methods
branch
from
99cfcf3
to
e7fb530
Compare
|
Can this be merge soon? |
JediSange
approved these changes
Jun 27, 2018
|
I was working on a similar set of changes for this repo that I am about to make a PR for. This should definitely be merged in but I'm not sure if the person still maintains this. @sachams |
|
Just added #10 -- Pulled your work into that as I need it for something I'm working on professionally. Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for this lib. These methods need to be exported for use in Angular e2e (with TypeScript) tests.