add inputdata unit test #2682
Merged
add inputdata unit test #2682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahf708
added
the
AT: WIP
|
@bartgol this is already uncovering real fails 👀 there are missing data files... |
bartgol
reviewed
Jan 24, 2024
components/eamxx/cime_config/tests/test_inputdata_namelist_defaults_scream.py
Outdated
Show resolved
Hide resolved
|
Ugh... Some of these inputdata files are huge... So next step, either:
I doubt either will be enough to get us across here (best case scenario, these images are no more than 50 G or so). So, we may want to consider to ask the retrieve function to actually just check if the file exists or not (or downloadable or not) and just report quickly. In the future we can likely do something more systematic and do integrity checking as well, but that will have to wait. cc @rljacob: Do you want us to include something similar to eam defaults or other components defaults in the future? For eam defaults we will need to check for files ending in .nc and there are so many of them. |
|
I need more context. Don't really know what you're asking. |
Yes, sorry. Context is here: #2680. We should move the discussion there. |
|
mahf708
removed
the
AT: WIP
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
mahf708
added
the
AT: AUTOMERGE
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: mahf708 |
|
Status Flag 'Pull Request AutoTester' - Error: Jenkins Jobs - A user has pushed a change to the PR before testing completed. NEW EVENT 'committed', ID C_kwDOCEfuetoAKDQ5ZTg0NGY3YzY5OGIzZjVkNzdjMzZlYTc4ZjA2MjY2YWY4N2NmNDg... The Jenkins Jobs will be shutdown; Testing of this PR must occur again. |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Console Output (last 100 lines) : SCREAM_PullRequest_Autotester_Mappy # 4799 (click to expand)Console Output (last 100 lines) : SCREAM_PullRequest_Autotester_Weaver # 5264 (click to expand) |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
bartgol
reviewed
Jan 24, 2024
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: mahf708 |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
bartgol
reviewed
Jan 25, 2024
bartgol
reviewed
Jan 25, 2024
bartgol
reviewed
Jan 25, 2024
bartgol
approved these changes
Jan 25, 2024
|
I think this looks good now. I wonder whether you should "reinstate" some of the missing files, so we can verify that the action works as expected when it runs on master... |
After merge, I propose we remove this file from the server to test ... 😉 <spa_remap_file hgrid="ne120np4">${DIN_LOC_ROOT}/atm/scream/maps/map_ne30np4_to_ne120np4_mono_20220502.nc</spa_remap_file> |
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: mahf708 |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ bartgol ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Merge on Pull Request# 2682: IS A SUCCESS - Pull Request successfully merged |
E3SM-Autotester
removed
the
AT: AUTOMERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a job to monitor consistency between inputdata server files and what we have in our configs. The job runs at every PR, every push to master, and everyday at 000000 (not sure which time zone, maybe UTC). If the job fails, it will show up as failing (thus hopefully stopping the PR from going in, not sure how that plays with the AT though). Additionally, if the scheduled job fails (i.e., not the PR or push to master), then a bot will create an issue with details for follow-up assigning Naser and Luca for now. What's more the workflow can be triggered manually. If an issue exists, the bot will simply append to it by adding more comments. We reserve the notify-file-gh-action for this specific workflow.
To test the automated issue-creation part, we should delete the following file and see when/if this workflow catches the discrepancy.
Accidental example of what the bot will create: #2683