-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gptl include and remove Kokkos_ROOT settings #2866
Conversation
Are we going to have differences in e3sm/scream repo? Or will this be downstreamed to e3sm? |
Jim, do you think we should fix this in the upstream? Or maybe just do a downstream merge (which we were planning anyways) when this is merged? Edit: ha! this time Noel beat me! |
I'm making the same change upstream, so it should be OK. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: jgfouca |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
SCREAM_PullRequest_Autotester_Mappy # 5537 FAILED (click to see last 100 lines of console output)
SCREAM_PullRequest_Autotester_Weaver # 5806 PASSED (click to see last 100 lines of console output)
|
Re-running the tests. Looking at the mappy fail, it's hard to see what went wrong. It claims the build failed but I don't see a build error anywhere. Also, it seems to work OK when I run it myself. |
When I try to build on pm-cpu with
If I replace all of those
but still fails:
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: jgfouca |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
SCREAM_PullRequest_Autotester_Mappy # 5539 FAILED (click to see last 100 lines of console output)
SCREAM_PullRequest_Autotester_Weaver # -1 SKIPPED |
Jim: you said this fixed build errors on pm-cpu. What tests did you run? You can see the test I ran to get build error. |
@ndkeen something is up with your repo. |
Noel, i think you tried the e3sm branch though, no? At least that's my understanding from the slack convo. This PR is in the scream repo, where |
ah, ok. i just made this comment on the wrong PR. |
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: jgfouca |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
SCREAM_PullRequest_Autotester_Mappy # 5550 FAILED (click to see last 100 lines of console output)
SCREAM_PullRequest_Autotester_Weaver # -1 SKIPPED |
* origin/master: (151 commits) Update EKAT submodule EAMxx: fix relative humidity unit test EAMxx: fix usage of code deprecated in Kokkos 4 Update haero submodule Fix uninitialized variable and a few Cuda compiler warnings. EAMxx: fixes to coarsening/vertical remappers, related to masks EAMxx: refactor vertical interpolation EAMxx: add utility method to FieldLayout Turns out that the MurphyKoop function only needs the ice flag to determine whether to take ice into consideration. So the PR reduces to changing that flag to true. allows for computing qv_sat_ice when T < T_freeze for RH diagnostic Adds a cime test for aci Fixed a layout and Clang format Fixes LABLES of the tests to change mam to mam4_aci for time reporting Fixes warnings and changes [=] to [&] GPU fixes: changes array of views to views in Kokkos loop Changes TeamThreadRange to TeamVectorRange; [=] to [&]; removes aitken dia func with deep_copy Adds some TODO comments and minor cleanup Fixes np1_vs_npX standalone tests and adds mam4xx vars to output Changes after rebase Updates CMAKE for the aci tests to mimic P3 CMAKE to enable np1 vs npX tests ...
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: jgfouca |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
|
Confirmed that this fixes all build errors for eamxx CIME cases on pm-cpu.