-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix usage of code deprecated Kokkos code, and updates ekat #2867
Fix usage of code deprecated Kokkos code, and updates ekat #2867
Conversation
Am i going crazy? I don't see the ekat submodule being updated? |
I forgot to push the commit, but you should see it now. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
SCREAM_PullRequest_Autotester_Mappy # 5545 PASSED (click to see last 100 lines of console output)
SCREAM_PullRequest_Autotester_Weaver # 5812 FAILED (click to see last 100 lines of console output)
|
Looks like weaver failed |
a499d79
to
83d015a
Compare
We still have the issue that test-all-scream does not really updates baselines when running through the AT (something is amiss with the master merge and the ahead/behind calculation). I am manually forcing baseline regen now. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: bartgol |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
All Jobs Finished; status = PASSED, target_sha=b7ba1720d6845735ef93f9bc233d3a1eeb0024e7, However Inspection must be performed before merge can occur... |
2 similar comments
All Jobs Finished; status = PASSED, target_sha=b7ba1720d6845735ef93f9bc233d3a1eeb0024e7, However Inspection must be performed before merge can occur... |
All Jobs Finished; status = PASSED, target_sha=b7ba1720d6845735ef93f9bc233d3a1eeb0024e7, However Inspection must be performed before merge can occur... |
We can now build with
Kokkos_ENABLE_DEPRECATED_CODE_4=OFF
. Also, brings in an update in ekat that suppresses the zillion warnings we were getting.@jgfouca I did not set
Kokkos_ENABLE_DEPRECATED_CODE_4=OFF
in our test-all-scream builds. But maybe we should consider doing it at some point?