Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix ncrna annotation track color #348

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

MGS-sails
Copy link
Contributor

Genomes that have more than one track color picker, were failing to load functional-annotation values that were preset from the query params. This was caused by the defaultValue functionality, which was originally written without consideration to deep linked values from query params. This pull request contains an adjustment that addresses this problem

Copy link
Member

@SandyRogers SandyRogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mahfouz! Couple of minor comments/queries in line.

src/components/Genomes/Browser/index.tsx Outdated Show resolved Hide resolved
src/components/IGV/TrackColourPicker/index.tsx Outdated Show resolved Hide resolved
src/utils/igvBrowserHelper.ts Outdated Show resolved Hide resolved
Copy link
Member

@SandyRogers SandyRogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MGS-sails MGS-sails merged commit 1af7195 into develop Feb 1, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants