Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prase.nf results are optional. #123

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

mberacochea
Copy link
Member

@mberacochea mberacochea commented Apr 30, 2024

This is to prevent the pipeline from "failing" when there are no viral annotations.

With these changes, the pipeline now finishes in the parse.nf step and produces partial results:

$ ls -l results
total 2511
drwxrwsr-x 2 mbc metagen    4096 Apr 30 19:05 01-viruses
drwxrwsr-x 2 mbc metagen    4096 Apr 30 19:06 08-final
-rw-rw-r-- 1 mbc metagen 1285574 Apr 30 19:00 MGYG000437699_renamed.fasta
-rw-rw-r-- 1 mbc metagen 1285574 Apr 30 19:00 MGYG000437699_renamed_filt1500bp.fasta
-rw-rw-r-- 1 mbc metagen       0 Apr 30 19:06 virsorter_metadata.ts

$ cat results/08-final/MGYG000437699_virus_predictions.log 
Overall, no putative _viral contigs or prophages were detected in the analysed metagenomic assembly
PPR-Meta found 0 low confidence contigs.
Virus Finder found 0 high confidence contigs.
Virus Finder found 0 low confidence contigs.
Contig has an invalid category : 6
Virus Sorter found 0 high confidence contigs.
Virus Sorter found 0 low confidence contigs.
Virus Sorter found 0 putative prophages contigs.

The current behaviour is confusing, as nextflow will mark the pipeline as failed even though it's not a "runtime" error, it's just that there are no viral sequences found.

This is to prevent the pipeline from "failing" when there are no
viral annotations.
@mberacochea mberacochea self-assigned this Apr 30, 2024
@mberacochea mberacochea marked this pull request as ready for review April 30, 2024 22:14
Copy link
Collaborator

@hoelzer hoelzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see! Wild, seems we never tested w/ "non-viruses" : ) Thanks!

@mberacochea mberacochea merged commit d166936 into dev May 7, 2024
1 check passed
mberacochea added a commit that referenced this pull request May 8, 2024
Merge small set of fixes for new release #123
@mberacochea mberacochea deleted the feature/optional-parse-results branch July 20, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants