Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse sequences in Rust/wasm #4

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

luizirber
Copy link
Contributor

sourmash-bio/sourmash#3047 implemented sequence parsing using niffler + needletail, which allows FASTA/FASTQ, as well as gz or uncompressed files.

This PR are the changes needed to use the package generated from that PR. Once that PR is merged and released it can be used directly here, but wanted to leave this open to allow commenting on the changes I did to make it work on the component.

@luizirber
Copy link
Contributor Author

I updated A LOT of dependencies, please let me know if I overdid it 😅

@luizirber
Copy link
Contributor Author

I added the wasm-pack output of sourmash-bio/sourmash#3047 to pkg/ temporarily to make it easier to verify, but it will obviously be pulled from NPM in the future

@SandyRogers
Copy link
Member

@luizirber Thank you very much for this PR! @MGS-sails : let's have a chat about this one, I think you were interested in looking into this web assembly piece?

@MGS-sails
Copy link
Contributor

@luizirber Thank you very much for this PR! @MGS-sails : let's have a chat about this one, I think you were interested in looking into this web assembly piece?

@SandyRogers Yes, It'd be great to have a chat about this.

Thanks !!

@luizirber
Copy link
Contributor Author

Now it uses the released sourmash 0.13.1

@luizirber luizirber marked this pull request as ready for review April 3, 2024 02:18
src/index.ts Outdated Show resolved Hide resolved
Co-authored-by: Tessa Pierce Ward <bluegenes@users.noreply.github.com>
luizirber added a commit to sourmash-bio/branchwater that referenced this pull request Apr 17, 2024
- Allow running in {docker,podman}-compose
- Add docs and initial tutorial for deploying a new instance with
example datasets
- Bring in the search index as additional Docker container in compose
- Use pixi for dep management
- Trigger metadata update for mongodb outside image creation, use only
one mongodb container in compose
- Add sentry for monitoring (opt-in)
- Flask app checks for errors from the search index
- Use docker links to connect to mongodb and search index by container
name
- Update mgnify component to (unreleased) one containing better sequence
parsing:
EBI-Metagenomics/mgnify-sourmash-component#4
- Update sourmash to 0.13.0 (rust) and use new APIs for revindex
- Add snakemake rules for building search index from example datasets

---------

Co-authored-by: Tessa Pierce Ward <bluegenes@users.noreply.github.com>
@MGS-sails
Copy link
Contributor

@luizirber sorry for taking so long to get back to you on this.
@SandyRogers the pull request looks good to me.
I pulled this and tested it locally on our web client and it works as normal.
The addition of the fastq file support works as expected and I can also see that sketching is happening client side.

@MGS-sails MGS-sails merged commit f1ab924 into EBI-Metagenomics:main Aug 1, 2024
1 check passed
@luizirber luizirber deleted the lirber/seqparser branch August 1, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants