Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store additional beam metadata #396

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

RemiLehe
Copy link
Member

@RemiLehe RemiLehe commented Jul 5, 2023

In offline discussions with @s-sajid-ali, it was proposed to add particle_mass, beta_ref, gamma_ref as attributes in the openPMD file, in order to make the ImpactX output readable by Synergia.

Copy link
Member

@cemitch99 cemitch99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@RemiLehe RemiLehe changed the title [WIP] Store additional beam metadata Store additional beam metadata Jul 11, 2023
@RemiLehe RemiLehe merged commit 1724569 into ECP-WarpX:development Jul 11, 2023
12 of 13 checks passed
@ax3l
Copy link
Member

ax3l commented Jul 18, 2023

This is great, thank you!

We can as a follow-up generalize this to use the openPMD BeamPhysics extension by @ChristopherMayes @DavidSagan 🌟
https://github.com/openPMD/openPMD-standard/blob/upcoming-2.0.0/EXT_BeamPhysics.md

@ax3l ax3l self-requested a review July 18, 2023 18:26
@ax3l ax3l added the component: diagnostics all types of outputs label Jul 18, 2023
@DavidSagan
Copy link

Note: the BeamPhysics extension uses the species instead of particle mass, totalMomentumOffset instead of a ref beta or ref gamma.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: diagnostics all types of outputs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants