-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: Intro Update #692
Doc: Intro Update #692
Conversation
Looks good! A couple of comments/suggestions:
|
Updated the intro paragraphs with ideas we discussed in the weekly meeting.
Thanks, updated :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I suggest that there is a follow-up paragraph reproducing some of the text from the IMPACT-Z description (most importantly, examples of applications), an stating explicitly that tracking methods are symplectic. I can contribute this if we agree on where it should be located.
Thanks, @cemitch99! Oh yes, I forgot that we wanted to reuse text from the readme in https://github.com/impact-lbl/IMPACT-Z. Feel free to contribute here or we merge and do a follow-up PR to add more. I think in the |
Co-authored-by: Chad Mitchell <46825199+cemitch99@users.noreply.github.com>
Updated the intro paragraphs with ideas we discussed in the weekly meeting.