[New ruleset] hoccer.com

[rugk]

No description provided.

[rugk]

Any news? And BTW: <securecookie host="." name="." /> is valid and just includes all cookies from this domain, is not it?

[jeremyn]

Thanks @rugk.

• There are various issues with the ruleset, so please change it to look like this:

<!--
	Invalid certificate:
		api.hoccer.com
		developer.hoccer.com
		stats.hoccer.com
		hoccer-project.com
		www.hoccer-project.com
		stats.hoccer-project.com

-->
<ruleset name="Hoccer">

	<target host="hoccer.com" />
	<target host="www.hoccer.com" />
	<target host="faq.hoccer.com" />
	<target host="invite.hoccer.com" />

	<target host="hoccer-project.com" />
	<target host="www.hoccer-project.com" />

	<securecookie host="^(www|faq|invite)\.hoccer\.com$" name=".+" />

	<rule from="^http://(www\.)?hoccer-project\.com/"
		to="https://hoccer.com/" />

	<rule from="^http:"
		to="https:" />

</ruleset>

This:

• adds new targets and identifies some non-working domains
• changes the ruleset name because it now covers both hoccer.com and hoccer-project.com
• modifies the securecookie to be more targeted, given the number of non-working domains. Also following our style guide here, .+ is the preferred way of saying "match everything".
• adds rewrite for (www.)?hoccer-project.com to hoccer.com.

Please let me know if you have any concerns about these changes.

• Also, we like to squash-and-merge rulesets, which means we combine and rewrite commits in your name. Is that all right with you for this and any other pull requests you submit to us?

[rugk]

Also, we like to squash-and-merge rulesets, which means we combine and rewrite commits in your name. Is that all right with you for this and any other pull requests you submit to us?

Yes, that's all right.

[jeremyn]

My mistake on the failed tests. In this line, change (www.) to (www\.). The first way is wrong. I had it the wrong way in #6230 (comment) and have now updated it. I'm sorry about that.

[jeremyn]

Thanks, merged.