Skip to content
This repository has been archived by the owner on Nov 6, 2023. It is now read-only.

Update srg-ssr.xml #8551

Merged
merged 5 commits into from
May 4, 2017
Merged

Update srg-ssr.xml #8551

merged 5 commits into from
May 4, 2017

Conversation

J0WI
Copy link
Contributor

@J0WI J0WI commented Feb 19, 2017

No description provided.

@J0WI
Copy link
Contributor Author

J0WI commented Apr 13, 2017

@jeremyn this is the only PR blocking #8833. Can we get rid of the downgrade here?

@ivysrono
Copy link
Contributor

Maybe you can empty the downgrade-whitelist.txt

@jeremyn
Copy link
Contributor

jeremyn commented Apr 13, 2017

https://ws.srf.ch (examples: https://ws.srf.ch/cr/zNxFwFy?iframe=true , https://ws.srf.ch/cr/zN5QNP9?iframe=true ) look okay to me, except for some mixed content blocking that seems harmless.

@J0WI
Copy link
Contributor Author

J0WI commented Apr 15, 2017

I can confirm that the mixed content is trivial. Is there anything else preventing this from merge?

@jeremyn
Copy link
Contributor

jeremyn commented Apr 17, 2017

@J0WI I'm not sure if you're asking me or @ivysrono , but I haven't reviewed this beyond the one comment I made above.

@ivysrono
Copy link
Contributor

@J0WI is asking you @jeremyn

@ivysrono
Copy link
Contributor

I will not have time to do these complex rules after this week.

@J0WI
Copy link
Contributor Author

J0WI commented Apr 29, 2017

@jeremyn can we get rid of this last downgrade for the next release?

@jeremyn
Copy link
Contributor

jeremyn commented Apr 29, 2017

@J0WI Are you asking me to do a general review of this pull request or are you asking me something more specific?

@J0WI
Copy link
Contributor Author

J0WI commented Apr 30, 2017

I'm asking you for a review to resolve #8833.

@jeremyn
Copy link
Contributor

jeremyn commented May 4, 2017

I get Secure connection failed but these are listed as Refused:

This works for me but is listed as HTTP redirect:

I get HTTP redirect but this has a target:

These work for me but they have HTTP redirect exclusions:

Also:

  • https://www.swissinfo.ch/fre and https://www.swissinfo.ch/eng work for me but there are a bunch of exclusions and tests here, and (www\.)?swissinfo.ch is listed as HTTP redirect here. Is there anything wrong with these URLs?
  • There's a downgrade comment in Craigslist.org.xml here that I guess should be removed, since there is no downgrade in that ruleset.

@jeremyn jeremyn self-assigned this May 4, 2017
@J0WI
Copy link
Contributor Author

J0WI commented May 4, 2017

Great, therefore we can also remove those exclusions.
See #9791 for Craigslist.org.xml

@jeremyn jeremyn merged commit cc9b16c into EFForg:master May 4, 2017
@jeremyn jeremyn removed their assignment May 4, 2017
@J0WI J0WI deleted the srg-ssr-up branch May 4, 2017 16:38
@J0WI
Copy link
Contributor Author

J0WI commented May 4, 2017

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants