Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for compatibility with Omeka #12

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Conversation

timstallmann
Copy link
Contributor

Hi! I'm so glad I found this plugin -- just a small PR to:

  • Change the plugin.php file to be compatible with modern Omeka plugin syntax
  • Upgrade dependencies
  • Add a new isObjectAvailable method, which mirrors the method in the Zend_S3 plugin (to check if an object exists).

@mikesname
Copy link
Contributor

@timstallmann thanks! Does the composer.json file also need to be updated? Also, would you mind bumping the plugin version to something like 1.1.0 in the plugin.ini file in the patch?

@timstallmann
Copy link
Contributor Author

Version number changed! And composer.json is fine as is, just the composer.lock needed to be changed -- aws-sdk-php is still on major version 3.

@mikesname mikesname merged commit 4bfab51 into EHRI:master Apr 18, 2023
@mikesname
Copy link
Contributor

@timstallmann I'm afraid I merged this a bit hastily yesterday and missed something.

Will it inconvenience you if I change the name of the class from OmekaAmazonS3StorageAdapterPlugin to just AmazonS3StorageAdapterPlugin? This is most plugins I'm aware of do not have the prefix, it's not an Omeka internal class, and it would also require us to reinstall rather than upgrade our many existing instances.

Sorry about that!

@timstallmann
Copy link
Contributor Author

timstallmann commented Apr 19, 2023

For sure, no problem, sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants