ENH: Meson pybind11 build #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
@galabovaa does this look alright? |
|
Looks fine to me from a meson perspective. |
galabovaa
approved these changes
Jul 16, 2023
|
Looks good to me! Merging in latest. Thank you for the time and effort you spent on this. I will now try to build highspy for all platforms with meson locally. |
This was referenced Jul 21, 2023
|
This is great guys! When will the next release of highspy be uploaded on pypi with all these fixes? |
|
I don't know, but it might not be long now that @galabovaa is back from holiday |
|
Hi I'd love to see this on pypi! I'm building from source and working off an open PR on python-mip. Getting working wheels on pypi would make it a lot easier to use this excellent solver! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs #1336. Closes #1321, #1320, and #1022. The wheels should be built correctly (i.e. built with
cibuildwheeland repaired byauditwheel,delocateanddelvewheel) formanylinux,musllinux, windows (arm_64), andmacos(botharm64andx86_64) [as seen here] so it should fix the existing broken wheel issues, that is it:highspy#1119@galabovaa this will be hard to review in its current state, but after #1336 is merged and I rebase onto latest, the change-set will contain just the Python changes and it will be easier to review. @eli-schwartz had some great comments on the original PR.
The windows issues were known problems discussed upstream as well:
But for users consuming wheels from PyPI or building locally it isn't an issue.