highspy: updated highs_linear_expression to be immutable for issue #1888 #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added __repr__ for easier debugging and pretty print linear expressions * added __iadd__ for mutable operations * added qsum for faster aggregation * updated chained comparison support to work in immutable setting
|
I can't comment on the implementation (I don't know Python well), other than to say that, at minimum, this needs a bunch of tests. |
Agreed. Working on this now, will update PR. BTW: the code changes for immutability are very simple. The chained comparison support definitely needs more testing, and I believe I've already found a couple of edge cases that need attention. |
…olver to allow complete plotting
Mip log plotter
`col_ecol_offset` now set - as const - for greater clarity
Initialize some arrays
…est solution is NaN
plot_highs_log.py now avoids printing spurious incumbent lines when best solution is NaN
…tatic extern int Highs_passHessian, private static extern int Highs_passModel and private static extern int Highs_getHessianNumNz to highs_csharp_api.cs
This was referenced Aug 30, 2024
… data to be contiguous with additional flags to array_t.
…iGHS into useStdArray # Conflicts: # src/util/HighsHashTree.h
Some minor changes
Replace hot FDIVs with FMULs through saving off the inverse values outside the loops, so we don't incur the cost on each loop iteration.
Precompute expensive computations
Revert "Precompute expensive computations"
* additional tests (with >99% coverage) * performance improvements * added support for calculating a value from expression * added support for getting expression for a given constraint * various bug fixes * made behaviour more consistent/intuitive * improved numpy interability * improved error reporting/handling
Release GIL and Run in Background Thread
* added __repr__ for easier debugging and pretty print linear expressions * added __iadd__ for mutable operations * added qsum for faster aggregation * updated chained comparison support to work in immutable setting
… data to be contiguous with additional flags to array_t.
* additional tests (with >99% coverage) * performance improvements * added support for calculating a value from expression * added support for getting expression for a given constraint * various bug fixes * made behaviour more consistent/intuitive * improved numpy interability * improved error reporting/handling
* Added GIL acquire for python callbacks * Added support for user_callback_data
* added callback support * added user/keyboard interrupt support * fixed issues with deadlock on windows * fixed MIP solution callback issue * added resetGlobalScheduler * released GIL for Presolve * improved setCallback * updated unit tests for 99% coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes should fix #1888
__repr__for easier debugging and pretty print linear expressions__iadd__for mutable operationsqsumfor faster aggregationexpr == [lb,ub]->lb <= expr <= ubsyntaxNote there are some low-risk caveats for the chained comparison support. I have documented them in the code. Though I believe the benefits outweigh the potential concerns.