Fixes #65 Null pointer Exeption in DeleteFromWithoutWhereCheck

EXXETA · Feb 7, 2018 · caa1bc1 · caa1bc1
1 parent c8c5fdd
commit caa1bc1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/esql-checks/src/main/java/com/exxeta/iss/sonar/esql/check/DeleteFromWithoutWhereCheck.java b/esql-checks/src/main/java/com/exxeta/iss/sonar/esql/check/DeleteFromWithoutWhereCheck.java
@@ -42,7 +42,9 @@ public void visitPassthruStatement(PassthruStatementTree tree) {
 		String statement = null;
 		if (SyntacticEquivalence.skipParentheses(tree.expression()) instanceof LiteralTree) {
 			statement = ((LiteralTree) SyntacticEquivalence.skipParentheses(tree.expression())).value().trim();
-		} else if (SyntacticEquivalence
+		} else if (tree.expressionList()!=null 
+				&& !tree.expressionList().parameters().isEmpty() 
+				&& SyntacticEquivalence
 				.skipParentheses(tree.expressionList().parameters().get(0)) instanceof LiteralTree) {
 			statement = ((LiteralTree) SyntacticEquivalence.skipParentheses(tree.expressionList().parameters().get(0)))
 					.value().trim();

diff --git a/esql-checks/src/test/resources/deleteFrom.esql b/esql-checks/src/test/resources/deleteFrom.esql
@@ -11,6 +11,8 @@ CREATE COMPUTE MODULE a
 		PASSTHRU(('DELETE FROM users WHERE NAME=''name''')); --Ccompliant
 		PASSTHRU(STMT); --Compliant
 		PASSTHRU('SELECT * FROM dual'); --Compliant
+		PASSTHRU loadStatement(); --Compliant
+		PASSTHRU (); --Compliant
 	END;
 
 END MODULE;