Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Son Belges #62

Open
BoulASA opened this issue Dec 2, 2022 · 5 comments
Open

Son Belges #62

BoulASA opened this issue Dec 2, 2022 · 5 comments
Assignees

Comments

@BoulASA
Copy link

BoulASA commented Dec 2, 2022

Serait-il possible de générer les sons suivants pour la Belgique et la Suisse ? Merci d'avance

.../fr/SYSTEM/
0070.wav --> Septante
0071.wav --> Septante et un
0072.wav --> Septante deux
0073.wav --> Septante trois
0074.wav --> Septante quatre
0075.wav --> Septante cinq
0076.wav --> Septante six
0077.wav --> Septante sept
0078.wav --> Septante huit
0079.wav --> Septante neuf

0090.wav --> Nonante
0091.wav --> Nonante et un
0092.wav --> Nonante deux
0093.wav --> Nonante trois
0094.wav --> Nonante quatre
0095.wav --> Nonante cinq
0096.wav --> Nonante six
0097.wav --> Nonante sept
0098.wav --> Nonante huit
0099.wav --> Nonante neuf

@pfeerick
Copy link
Member

Would it be possible to generate the following sounds for Belgium and Switzerland? Thanks in advance

I'm not quite sure what you are actually after here... it seems like Belgium has three main languages - Dutch (Flemish), French, and German, and Switzerland uses either Swiss German or Standard German...

Are you saying that the current version of 70-79 and 90-99 don't sound right for the French voice pack?

@gonzalo-bulnes
Copy link
Contributor

I know what @BoulASA meant here, it is a request to create new locales for the French language.

The numbers sound right for the fr-FR sound pack (French, locale France). However, in the fr-BE (Belgium) and fr-CH (Switzerland) locales, numbers in the 70-99 range are read differently.

Those locales are available in Azure Speech Services (e.g. fr-BE-GerardNeural, fr-CH-ArianeNeural).

@pfeerick
Copy link
Member

pfeerick commented Jan 3, 2024

So does it require a separate CSV, or can the current fr-FR.csv be used? Meaning just needs two more lines in generate.sh to create the new voices, and sounds.json updated.

@gonzalo-bulnes
Copy link
Contributor

gonzalo-bulnes commented Jan 3, 2024

I think it makes sense to create a new file, say, fr-BE.csv. This exactly a difference in locale (vs language) and the fr-FR.csv it correct in its own context (FR).

I am not aware of differences between fr-BE and fr-CH that could apply to the current EdgeTx strings, so I'd start with one new file, and expand if someone asks for it. (People in Belgium and Switzerland tend to sound different, but that's a voice aspect not locale, so that wouldn't necessarily require a new file. I'm sure someone will eventually point out if there are differences in locale that make the distinction between fr-BE and fr-CH useful.)

@gonzalo-bulnes
Copy link
Contributor

gonzalo-bulnes commented Jan 4, 2024

Wait, I just looked into adding the fr-BE file and realized I had missed something.

Since the numbers in the 70-99 range are specified as numbers (e.g. 70, not soixante-dix or septante) then the fr-BE file would actually be identical to the fr-FR file, and it is the text-to-speech service that would make the difference. I'd expect that picking a voice for the fr-BE locale like fr-BE-GerardNeural will read 70 a septante.

Meaning just needs two more lines in generate.sh to create the new voices, and sounds.json updated.

I still think it makes sense to have a file per locale, because they are different locales, but the smallest acceptable change in this case is what you said @pfeerick.

./voice-gen.py voices/fr-FR.csv fr-BE-GerardNeural fr || exit 1
./voice-gen.py voices/fr-FR.csv fr-CH-ArianeNeural fr || exit 1
    {
        "language": "fr-BE",
        "name": "French (BE)",
        "description": "French Male Voice (fr-BE-GerardNeural)",
        "directory": "fr"
    },
    {
        "language": "fr-FR",
        "name": "French (CH)",
        "description": "French Female Voice (fr-CH-ArianeNeural)",
        "directory": "fr"
    },

Note: Because the fr-FR file is in that state where the reference strings are in French too, I think I'd personally opt for applying that shortcut change instead of multiplying the number of files that need to be fixed later. YMMV

Edit: I'm not set up to generate the new sounds yet, that's why I'm not opening a PR.

@pfeerick pfeerick self-assigned this May 30, 2024
pfeerick added a commit that referenced this issue May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants