Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOMERGE: [0.17] Signet implementation #433

Closed
wants to merge 4 commits into from

Conversation

jtimon
Copy link
Contributor

@jtimon jtimon commented Oct 14, 2018

A rebase of kallewoof/bitcoin#5 on top of #432 taking the opportunity to simplify its changes around chainparams code and adding a test that also acts as a script to generate a private key in wallet importable format and its corresponding p2pk blockscript, which should be useful for people wanting to generate their own signets.
This represent a hardfork from that implementation because the genesis block now includes the name of the chain too, like all other custom chains, and the bits have to be low enough so that tests keep working with regtest-like pow.

Example to generate chain arguments:

python3 ./test/functional/test_runner.py feature_signet --config_path=/home/user/signet

That will generate:

/home/user/signet/signet_blockscript.txt
/home/user/signet/wif.txt

Dependencies:

@jtimon jtimon force-pushed the e17-signet branch 4 times, most recently from 7e93457 to 2b3b8c8 Compare October 14, 2018 22:36
@jtimon jtimon force-pushed the e17-signet branch 6 times, most recently from cc0f135 to 93d75f3 Compare October 16, 2018 18:29
jtimon added a commit to jtimon/elements that referenced this pull request Oct 16, 2018
jtimon added a commit to jtimon/elements that referenced this pull request Oct 16, 2018
@jtimon jtimon added the 0.17 label Oct 16, 2018
@jtimon jtimon force-pushed the e17-signet branch 2 times, most recently from e55e65e to 5e9632a Compare October 17, 2018 04:52
@jtimon jtimon changed the title [0.17] Signet implementation NOMERGE: [0.17] Signet implementation Oct 17, 2018
log "hit ^C to stop"

while true; do
let rv=$RANDOM%$randinterval
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs +$min_time

@instagibbs
Copy link
Collaborator

We're going to work directly on a branch, rather than a PR on top of elements-0.17.

@instagibbs instagibbs closed this Oct 29, 2018
@jtimon
Copy link
Contributor Author

jtimon commented Nov 22, 2018

You're going to need at least part of it here too, assuming #414 is merged and forward ported. putting it all facilitates testing since you wouldn't need a separated binary to test the fedpeg to a parent signet anymore.
But your call.

@instagibbs
Copy link
Collaborator

Not going to delete the branch to be clear. I made a copy to the repo: https://github.com/ElementsProject/elements/tree/e17-signet

IIRC I was getting conflicts as the base branch was moving along with features, and for now we just wanted a 0.17 Core branch to work on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants