Skip to content

Commit

Permalink
We state not to do 'any local DNS' if --always-use-proxy flag is set,…
Browse files Browse the repository at this point in the history
… so we should this

Even if it is on startup only once ...
Like @bitcoin-software indicated the expected UX should be in
line with what a user expects the software will do
so we should not dns if we say so with a flag that suggest that.

Changelog-Fixed: We disable all dns even on startup the scan for bogus dns servers, if --always-use-proxy is set true

Signed-off-by: Saibato <saibato.naga@pm.me>
  • Loading branch information
Saibato committed Nov 8, 2019
1 parent c62f0cb commit 4bf2bbc
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions connectd/connectd.c
Original file line number Diff line number Diff line change
Expand Up @@ -1180,9 +1180,12 @@ static struct io_plan *connect_init(struct io_conn *conn,
} else
daemon->proxyaddr = NULL;

if (broken_resolver(daemon)) {
status_debug("Broken DNS resolver detected, will check for "
"dummy replies");
/* We state not to do 'any local DNS' if flag is set so we should do this */
if (!daemon->use_proxy_always) {
if (broken_resolver(daemon)) {
status_debug("Broken DNS resolver detected, will check for "
"dummy replies");
}
}

/* Figure out our addresses. */
Expand Down

0 comments on commit 4bf2bbc

Please sign in to comment.