Skip to content

Commit

Permalink
CI: enable stack protection for -O3 and experimental builds
Browse files Browse the repository at this point in the history
Because these are a *developer* builds, we don't get
-fstack-protector!  So add it here in both places.

This would have caught the bug found in the next commit.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
  • Loading branch information
rustyrussell committed Aug 31, 2021
1 parent 2770bcb commit 5f1bf50
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,14 @@ jobs:
TEST_CMD: "make"
- CFG: "make-O3-check"
TEST_CMD: "make check-source check-units installcheck check-gen-updated"
COPTFLAGS: "-O3"
COPTFLAGS: "-O3 -fstack-protector-strong"
- CFG: "make-32-bit-nodev-check"
ARCH: 32
TEST_CMD: "make check-source check-units installcheck"
DEVELOPER: 0
- CFG: "make-EXPERIMENTAL-check"
TEST_CMD: "make check-source check-units installcheck check-gen-updated"
COPTFLAGS: "-Og -fstack-protector-strong"
EXPERIMENTAL_FEATURES: 1
steps:
- name: Checkout
Expand Down

0 comments on commit 5f1bf50

Please sign in to comment.