Skip to content

Commit

Permalink
We state not to do 'any local DNS' if --always-use-proxy flag is set,…
Browse files Browse the repository at this point in the history
… so we should this

Even if it is on startup only once ...
Like @bitcoin-software indicated the expected UX should be in
line with what a user expects the software will do
so we should not dns if we say so with a flag that suggest that.

Changelog-Fixed: We disable all dns even on startup the scan for bogus dns servers, if --always-use-proxy is set true

Signed-off-by: Saibato <saibato.naga@pm.me>
  • Loading branch information
Saibato committed Nov 9, 2019
1 parent c62f0cb commit c3623ee
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions connectd/connectd.c
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,8 @@ static bool broken_resolver(struct daemon *daemon)
const char *hostname = "nxdomain-test.doesntexist";
int err;

/* If they told us to never do DNS queries, don't even do this one */
if (!daemon->use_dns) {
/* If they told us to never do DNS queries, don't even do this one and also not if we just say that we don't */
if (!daemon->use_dns || daemon->use_proxy_always) {
daemon->broken_resolver_response = NULL;
return false;
}
Expand Down Expand Up @@ -1182,7 +1182,7 @@ static struct io_plan *connect_init(struct io_conn *conn,

if (broken_resolver(daemon)) {
status_debug("Broken DNS resolver detected, will check for "
"dummy replies");
"dummy replies");
}

/* Figure out our addresses. */
Expand Down

0 comments on commit c3623ee

Please sign in to comment.