Drop dependency on python2 because it reached end-of-life #3552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We specify `PYTHON_VERSION=3` to prevent libwally's ./configure from searchin for python2, which some distros have started removing, and we were requiring it only for the configuration step anyway. Changelog-Changed: dependencies: We no longer depend on python2 which has reached end-of-life
We aren't using it and it's broken with the specified upstream image, so remove it outright.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building the v0.8.1 I noticed that some of the newer distros (Ubuntu Focal / 20.04) have started dropping the
pythonpackage, a.k.a. thepython2interpreter, because it has reached end-of-life as of January 1st.libwally-corewas the reason we introduced this dependency, since theconfigurescript aborts if it can't find apythonexecutable, despite later telling it not to bother building the python bindings. While we wait for them to make the executable optional we can force it to recognizepython3as a valid executable, thus freeing us from this requirement.I went through the docs and removed all references to the dependencies, and hopefully I got them all.