Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bitcoin backend: batch fee estimation requests #3570

Merged
merged 8 commits into from
Mar 30, 2020
Merged

Bitcoin backend: batch fee estimation requests #3570

merged 8 commits into from
Mar 30, 2020

Commits on Mar 27, 2020

  1. onchaind: a feerate per transaction type 

    This allows us to set more fine-grained feerate for onchain resolution.

We still give it the same feerate for all types, but this will change as
we move feerates to bcli.
    @darosior
    darosior committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    05f6a69 View commit details
    Browse the repository at this point in the history

  2. chaintopology: add delayed_to_us, htlc, and penalty feerates

    @darosior
    darosior committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    cfba7cc View commit details
    Browse the repository at this point in the history

  3. chaintopology: better feerate targets differentiation 

    We kept track of an URGENT, a NORMAL, and a SLOW feerate. They were used
for opening (NORMAL), mutual (NORMAL), UNILATERAL (URGENT) transactions
as well as minimum and maximum estimations, and onchain resolution.

We now keep track of more fine-grained feerates:
- `opening` used for funding and also misc transactions
- `mutual_close` used for the mutual close transaction
- `unilateral_close` used for unilateral close (commitment transactions)
- `delayed_to_us` used for resolving our output from our unilateral close
- `htlc_resolution` used for resolving onchain HTLCs
- `penalty` used for resolving revoked transactions

We don't modify our requests to our Bitcoin backend, as the next commit
will batch them !

Changelog-deprecated: The "urgent", "slow", and "normal" field of the `feerates` command are now deprecated.
Changelog-added: The fields "opening", "mutual_close", "unilateral_close", "delayed_to_us", "htlc_resolution" and "penalty" have been added to the `feerates` command.
    @darosior
    darosior committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    45c6613 View commit details
    Browse the repository at this point in the history

  4. lightning/bitcoind: adapt and batch fees estimations 

    This adapts our fee estimations requests to the Bitcoin backend to the
new semantic, and batch the requests.

This makes our request for fees much simpler, and leaves some more
flexibility for a plugin to do something smart (it could still lie before
but now it's explicit, at least.) as we don't explicitly request
estimation for a specific mode and a target.

Changelog-Changed: We now batch the requests for fee estimation to our Bitcoin backend.
Changelog-Changed: We now get more fine-grained fee estimation from our Bitcoin backend.
    @darosior
    darosior committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    a23e569 View commit details
    Browse the repository at this point in the history

  5. bcli: adapt interface to the new fees estimation interface 

    We keep the same behaviour as lightningd before.
    @darosior
    darosior committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    a2f4c9d View commit details
    Browse the repository at this point in the history

  6. chaintopology: Add the cost of HTLCs transactions to json_feerates 

    Changelog-Changed: "htlc_timeout_satoshis" and "htlc_success_satoshis" fields have been added to the `feerates` command.
    @darosior
    darosior committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    8b23168 View commit details
    Browse the repository at this point in the history

  7. libplugin: allow u32 options

    @darosior
    darosior committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    54f10d2 View commit details
    Browse the repository at this point in the history

  8. bcli: register --dev-max-fee-multiplier on our side 

    That way we pass the real min_acceptable (SLOW/2) and max_acceptable
(URGENT * 10) feerates to lightningd.
    @darosior
    darosior committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    eff7241 View commit details
    Browse the repository at this point in the history