v082 deprecations #3603
Merged
v082 deprecations #3603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Removed: JSON: `sendpay` `description` parameter removed (renamed to `label` in 0.7.0).
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Removed: JSON: `fundchannel` and `fundchannel_start` `satoshi` parameter removed (renamed to `amount` in 0.7.3).
…wasn't sent So we can't tell people they should use amount, until v0.8.2 is released. Another 6 months before we can deprecated the 'satoshi' field here :( Fixes: d149ba2 Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Fixed: JSON: `fundchannel_start` returns `amount` even when deprecated APIs are enabled. Changelog-Deprecated: JSON: `fundchannel_start` `satoshi` field really deprecated now (use `amount`).
…` and `localfeatures` Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Removed: JSON: `listnodes` `globalfeatures` output (`features` since in 0.7.3). Changelog-Removed: JSON: `listpeers` `localfeatures` and `globalfeatures` output (`features` since in 0.7.3). Changelog-Removed: JSON: `peer_connected` hook `localfeatures` and `globalfeatures` output (`features` since in 0.7.3).
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Removed: JSON: `close` `force` parameter removed (deprecated in 0.7.2.1)
This was referenced Mar 25, 2020
|
ACK 1649a72 Checked against the plugin repository 👍 |
cdecker
added a commit
to cdecker/lightning
that referenced
this pull request
Apr 6, 2020
While we removed the `satoshi` param in ElementsProject#3603 it appears that the `fundchannel` plugin was still passing it to the `fundchannel_start` call. This removes that shim and fixes up the help text. Notice that technically the help text changes the param name, but since it was internally always called `amount` this change doesn't break the API, the help was just wrong.
cdecker
added a commit
to cdecker/lightning
that referenced
this pull request
Apr 6, 2020
While we removed the `satoshi` param in ElementsProject#3603 it appears that the `fundchannel` plugin was still passing it to the `fundchannel_start` call. This fixes up the help text. Notice that technically the help text changes the param name, but since it was internally always called `amount` this change doesn't break the API, the help was just wrong.
cdecker
added a commit
to cdecker/lightning
that referenced
this pull request
Apr 8, 2020
While we removed the `satoshi` param in ElementsProject#3603 it appears that the `fundchannel` plugin was still passing it to the `fundchannel_start` call. This fixes up the help text. Notice that technically the help text changes the param name, but since it was internally always called `amount` this change doesn't break the API, the help was just wrong.
cdecker
added a commit
to cdecker/lightning
that referenced
this pull request
Apr 9, 2020
While we removed the `satoshi` param in ElementsProject#3603 it appears that the `fundchannel` plugin was still passing it to the `fundchannel_start` call. This fixes up the help text. Notice that technically the help text changes the param name, but since it was internally always called `amount` this change doesn't break the API, the help was just wrong.
rustyrussell
pushed a commit
that referenced
this pull request
Apr 10, 2020
While we removed the `satoshi` param in #3603 it appears that the `fundchannel` plugin was still passing it to the `fundchannel_start` call. This fixes up the help text. Notice that technically the help text changes the param name, but since it was internally always called `amount` this change doesn't break the API, the help was just wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not everything was in the Deprecated section of the changelog, so did a grep sweep.